Skip to content

docs(implementation-guide): fix incorrect example links#31962

Merged
mainframev merged 2 commits into
microsoft:masterfrom
mainframev:docs/component-impl-guide
Jul 10, 2024
Merged

docs(implementation-guide): fix incorrect example links#31962
mainframev merged 2 commits into
microsoft:masterfrom
mainframev:docs/component-impl-guide

Conversation

@mainframev

@mainframev mainframev commented Jul 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Simply fixes broken example links in component-implementation-guide after #31579, plus a few others that had wrong path to old wiki

@mainframev
mainframev requested review from a team as code owners July 10, 2024 12:38
fabricteam
fabricteam reviewed Jul 10, 2024
View reviewed changes
Comment thread docs/react-v9/contributing/component-implementation-guide.md
@mainframev
mainframev force-pushed the docs/component-impl-guide branch from 3131d27 to b6cf668 Compare July 10, 2024 12:49
@fabricteam

fabricteam commented Jul 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam

fabricteam commented Jul 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 626 614 5000
Button mount 292 296 5000
Field mount 1112 1144 5000
FluentProvider mount 713 718 5000
FluentProviderWithTheme mount 79 90 10
FluentProviderWithTheme virtual-rerender 33 34 10
FluentProviderWithTheme virtual-rerender-with-unmount 69 75 10
MakeStyles mount 878 904 50000
Persona mount 1767 1770 5000
SpinButton mount 1425 1401 5000
SwatchPicker mount 1657 1653 5000

fabricteam
fabricteam reviewed Jul 10, 2024
View reviewed changes
Comment thread docs/react-v9/contributing/component-implementation-guide.md
@fabricteam

fabricteam commented Jul 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
PortalMinimalPerf.default 87 86 1.01:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 86 78 1.1:1
CarouselMinimalPerf.default 284 259 1.1:1
LayoutMinimalPerf.default 204 185 1.1:1
FormMinimalPerf.default 227 209 1.09:1
FlexMinimalPerf.default 166 154 1.08:1
LoaderMinimalPerf.default 211 198 1.07:1
GridMinimalPerf.default 198 186 1.06:1
ListNestedPerf.default 347 328 1.06:1
ChatWithPopoverPerf.default 218 207 1.05:1
RefMinimalPerf.default 120 114 1.05:1
AnimationMinimalPerf.default 310 298 1.04:1
ButtonMinimalPerf.default 93 89 1.04:1
ImageMinimalPerf.default 225 216 1.04:1
TextAreaMinimalPerf.default 309 296 1.04:1
ItemLayoutMinimalPerf.default 721 699 1.03:1
RadioGroupMinimalPerf.default 264 257 1.03:1
DatepickerMinimalPerf.default 3834 3769 1.02:1
DialogMinimalPerf.default 453 446 1.02:1
DropdownManyItemsPerf.default 402 395 1.02:1
PopupMinimalPerf.default 355 347 1.02:1
VideoMinimalPerf.default 430 421 1.02:1
AvatarMinimalPerf.default 116 115 1.01:1
BoxMinimalPerf.default 216 213 1.01:1
ButtonOverridesMissPerf.default 670 663 1.01:1
ChatMinimalPerf.default 446 441 1.01:1
DropdownMinimalPerf.default 1462 1450 1.01:1
EmbedMinimalPerf.default 1905 1889 1.01:1
HeaderMinimalPerf.default 208 206 1.01:1
HeaderSlotsPerf.default 470 464 1.01:1
RosterPerf.default 1557 1540 1.01:1
ReactionMinimalPerf.default 210 207 1.01:1
SegmentMinimalPerf.default 200 198 1.01:1
IconMinimalPerf.default 396 391 1.01:1
CustomToolbarPrototype.default 1488 1479 1.01:1
LabelMinimalPerf.default 214 215 1:1
ListCommonPerf.default 402 403 1:1
ListMinimalPerf.default 308 309 1:1
AttachmentSlotsPerf.default 656 662 0.99:1
ButtonSlotsPerf.default 304 306 0.99:1
CardMinimalPerf.default 306 309 0.99:1
CheckboxMinimalPerf.default 1155 1165 0.99:1
InputMinimalPerf.default 541 547 0.99:1
ListWith60ListItems.default 373 377 0.99:1
MenuMinimalPerf.default 507 511 0.99:1
SkeletonMinimalPerf.default 198 201 0.99:1
SplitButtonMinimalPerf.default 2275 2299 0.99:1
MenuButtonMinimalPerf.default 960 978 0.98:1
ProviderMergeThemesPerf.default 653 667 0.98:1
ProviderMinimalPerf.default 195 198 0.98:1
SliderMinimalPerf.default 729 741 0.98:1
StatusMinimalPerf.default 386 394 0.98:1
TableManyItemsPerf.default 1099 1127 0.98:1
TableMinimalPerf.default 237 242 0.98:1
DividerMinimalPerf.default 207 214 0.97:1
ToolbarMinimalPerf.default 552 571 0.97:1
TooltipMinimalPerf.default 1252 1292 0.97:1
TreeMinimalPerf.default 496 509 0.97:1
AlertMinimalPerf.default 163 170 0.96:1
TextMinimalPerf.default 201 210 0.96:1
AccordionMinimalPerf.default 88 95 0.93:1
ChatDuplicateMessagesPerf.default 151 162 0.93:1
TreeWith60ListItems.default 81 88 0.92:1

@mainframev
mainframev force-pushed the docs/component-impl-guide branch from b6cf668 to 2dd7841 Compare July 10, 2024 13:02
@fabricteam

fabricteam commented Jul 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 608 640 5000
Breadcrumb mount 1708 1690 1000
Checkbox mount 1685 1688 5000
CheckboxBase mount 1469 1501 5000
ChoiceGroup mount 2896 2946 5000
ComboBox mount 670 668 1000
CommandBar mount 6532 6481 1000
ContextualMenu mount 12149 12297 1000
DefaultButton mount 785 797 5000
DetailsRow mount 2145 2196 5000
DetailsRowFast mount 2189 2186 5000
DetailsRowNoStyles mount 2007 2005 5000
Dialog mount 2805 2655 1000
DocumentCardTitle mount 229 233 1000
Dropdown mount 1993 2027 5000
FocusTrapZone mount 1140 1163 5000
FocusZone mount 1046 1073 5000
GroupedList mount 37323 41822 2
GroupedList virtual-rerender 20023 20204 2
GroupedList virtual-rerender-with-unmount 50933 50995 2
GroupedListV2 mount 221 228 2
GroupedListV2 virtual-rerender 216 211 2
GroupedListV2 virtual-rerender-with-unmount 226 230 2
IconButton mount 1136 1139 5000
Label mount 347 343 5000
Layer mount 2734 2728 5000
Link mount 397 398 5000
MenuButton mount 957 975 5000
MessageBar mount 21463 21896 5000
Nav mount 2029 2004 1000
OverflowSet mount 785 806 5000
Panel mount 1834 1797 1000
Persona mount 737 753 1000
Pivot mount 871 892 1000
PrimaryButton mount 911 945 5000
Rating mount 4598 4611 5000
SearchBox mount 895 905 5000
Shimmer mount 1941 1865 5000
Slider mount 1319 1339 5000
SpinButton mount 2922 2949 5000
Spinner mount 386 397 5000
SplitButton mount 1886 1810 5000
Stack mount 427 409 5000
StackWithIntrinsicChildren mount 883 881 5000
StackWithTextChildren mount 2840 2798 5000
SwatchColorPicker mount 6405 6322 5000
TagPicker mount 1420 1494 5000
Text mount 382 391 5000
TextField mount 946 938 5000
ThemeProvider mount 843 849 5000
ThemeProvider virtual-rerender 593 579 5000
ThemeProvider virtual-rerender-with-unmount 1277 1264 5000
Toggle mount 604 617 5000
buttonNative mount 192 194 5000

@fabricteam

fabricteam commented Jul 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam
fabricteam reviewed Jul 10, 2024
View reviewed changes
Comment thread docs/react-v9/contributing/component-implementation-guide.md
Hotell
Hotell approved these changes Jul 10, 2024
View reviewed changes
Comment thread docs/react-v9/contributing/component-implementation-guide.md Outdated
@mainframev
mainframev force-pushed the docs/component-impl-guide branch from b29223a to ec24329 Compare July 10, 2024 14:55
@mainframev mainframev self-assigned this Jul 10, 2024
@mainframev
mainframev merged commit 437e71d into microsoft:master Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments
@Hotell Hotell Hotell approved these changes

Assignees

@mainframev mainframev

Labels

Area: Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mainframev @fabricteam @Hotell