VRT secretless FIC#32043
Closed
Malleshnayak wants to merge 2 commits into
Closed
Conversation
Hotell
reviewed
Jul 18, 2024
Hotell
left a comment
Hotell
left a comment
Contributor
There was a problem hiding this comment.
can you please provide proper PR description in order to understand the intent of this PR ? ty
Author
|
@Hotell I don't intend to merge this PR but I want to run Visual regression tool specific checks on these changes [Cloned these changes from Tristin's changes], to troubleshoot existing issue we are facing on VRT. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Member
|
Converting this PR to draft for now |
TristanWatanabe
marked this pull request as draft
July 18, 2024 13:24
Collaborator
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 35 | 42 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 610 | 627 | 5000 | |
| Button | mount | 299 | 294 | 5000 | |
| Field | mount | 1104 | 1142 | 5000 | |
| FluentProvider | mount | 711 | 720 | 5000 | |
| FluentProviderWithTheme | mount | 86 | 94 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 35 | 42 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 81 | 72 | 10 | |
| MakeStyles | mount | 855 | 874 | 50000 | |
| Persona | mount | 1743 | 1703 | 5000 | |
| SpinButton | mount | 1374 | 1385 | 5000 | |
| SwatchPicker | mount | 1643 | 1631 | 5000 |
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 90 | 79 | 1.14:1 |
| ButtonMinimalPerf.default | 94 | 84 | 1.12:1 |
| TextAreaMinimalPerf.default | 313 | 286 | 1.09:1 |
| FlexMinimalPerf.default | 165 | 153 | 1.08:1 |
| LoaderMinimalPerf.default | 204 | 189 | 1.08:1 |
| AnimationMinimalPerf.default | 310 | 290 | 1.07:1 |
| SliderMinimalPerf.default | 765 | 712 | 1.07:1 |
| AvatarMinimalPerf.default | 113 | 107 | 1.06:1 |
| DropdownManyItemsPerf.default | 397 | 376 | 1.06:1 |
| RefMinimalPerf.default | 110 | 104 | 1.06:1 |
| AttachmentMinimalPerf.default | 85 | 81 | 1.05:1 |
| AttachmentSlotsPerf.default | 640 | 608 | 1.05:1 |
| FormMinimalPerf.default | 224 | 213 | 1.05:1 |
| ImageMinimalPerf.default | 232 | 220 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 156 | 150 | 1.04:1 |
| GridMinimalPerf.default | 195 | 188 | 1.04:1 |
| LabelMinimalPerf.default | 223 | 215 | 1.04:1 |
| BoxMinimalPerf.default | 197 | 191 | 1.03:1 |
| ChatMinimalPerf.default | 445 | 434 | 1.03:1 |
| ListNestedPerf.default | 311 | 303 | 1.03:1 |
| RadioGroupMinimalPerf.default | 264 | 257 | 1.03:1 |
| ReactionMinimalPerf.default | 214 | 208 | 1.03:1 |
| AccordionMinimalPerf.default | 85 | 83 | 1.02:1 |
| DropdownMinimalPerf.default | 1451 | 1429 | 1.02:1 |
| ListWith60ListItems.default | 379 | 370 | 1.02:1 |
| PortalMinimalPerf.default | 85 | 83 | 1.02:1 |
| TableMinimalPerf.default | 233 | 228 | 1.02:1 |
| TreeMinimalPerf.default | 490 | 480 | 1.02:1 |
| MenuMinimalPerf.default | 509 | 505 | 1.01:1 |
| TooltipMinimalPerf.default | 1255 | 1245 | 1.01:1 |
| AlertMinimalPerf.default | 160 | 160 | 1:1 |
| ChatWithPopoverPerf.default | 191 | 191 | 1:1 |
| DatepickerMinimalPerf.default | 3509 | 3510 | 1:1 |
| DialogMinimalPerf.default | 444 | 445 | 1:1 |
| EmbedMinimalPerf.default | 1885 | 1885 | 1:1 |
| HeaderMinimalPerf.default | 208 | 209 | 1:1 |
| ItemLayoutMinimalPerf.default | 713 | 715 | 1:1 |
| PopupMinimalPerf.default | 342 | 343 | 1:1 |
| ProviderMergeThemesPerf.default | 646 | 643 | 1:1 |
| ProviderMinimalPerf.default | 198 | 198 | 1:1 |
| SplitButtonMinimalPerf.default | 2250 | 2246 | 1:1 |
| StatusMinimalPerf.default | 393 | 394 | 1:1 |
| TextMinimalPerf.default | 196 | 196 | 1:1 |
| CustomToolbarPrototype.default | 1473 | 1478 | 1:1 |
| ButtonOverridesMissPerf.default | 640 | 646 | 0.99:1 |
| CardMinimalPerf.default | 307 | 311 | 0.99:1 |
| CarouselMinimalPerf.default | 255 | 258 | 0.99:1 |
| HeaderSlotsPerf.default | 452 | 457 | 0.99:1 |
| ListCommonPerf.default | 395 | 397 | 0.99:1 |
| SegmentMinimalPerf.default | 194 | 196 | 0.99:1 |
| TableManyItemsPerf.default | 1108 | 1124 | 0.99:1 |
| VideoMinimalPerf.default | 437 | 443 | 0.99:1 |
| DividerMinimalPerf.default | 201 | 205 | 0.98:1 |
| ListMinimalPerf.default | 304 | 309 | 0.98:1 |
| ToolbarMinimalPerf.default | 539 | 548 | 0.98:1 |
| CheckboxMinimalPerf.default | 1143 | 1179 | 0.97:1 |
| InputMinimalPerf.default | 533 | 549 | 0.97:1 |
| LayoutMinimalPerf.default | 193 | 198 | 0.97:1 |
| MenuButtonMinimalPerf.default | 954 | 982 | 0.97:1 |
| IconMinimalPerf.default | 373 | 385 | 0.97:1 |
| SkeletonMinimalPerf.default | 191 | 198 | 0.96:1 |
| ButtonSlotsPerf.default | 298 | 316 | 0.94:1 |
| RosterPerf.default | 1531 | 1664 | 0.92:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Jul 18, 2024
| @@ -29,15 +29,25 @@ jobs: | |||
| vrTestPackageName: '@fluentui/vr-tests-web-components' | |||
Collaborator
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask - RTL.normal.chromium.png | 4 | Changed |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 633 | 621 | 5000 | |
| Breadcrumb | mount | 1673 | 1697 | 1000 | |
| Checkbox | mount | 1676 | 1699 | 5000 | |
| CheckboxBase | mount | 1499 | 1502 | 5000 | |
| ChoiceGroup | mount | 2936 | 2999 | 5000 | |
| ComboBox | mount | 670 | 670 | 1000 | |
| CommandBar | mount | 6502 | 6595 | 1000 | |
| ContextualMenu | mount | 13244 | 12743 | 1000 | |
| DefaultButton | mount | 770 | 787 | 5000 | |
| DetailsRow | mount | 2199 | 2249 | 5000 | |
| DetailsRowFast | mount | 2268 | 2218 | 5000 | |
| DetailsRowNoStyles | mount | 2024 | 2042 | 5000 | |
| Dialog | mount | 2721 | 2812 | 1000 | |
| DocumentCardTitle | mount | 241 | 239 | 1000 | |
| Dropdown | mount | 2001 | 1994 | 5000 | |
| FocusTrapZone | mount | 1123 | 1185 | 5000 | |
| FocusZone | mount | 1090 | 1077 | 5000 | |
| GroupedList | mount | 42482 | 42043 | 2 | |
| GroupedList | virtual-rerender | 20323 | 20284 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51493 | 51423 | 2 | |
| GroupedListV2 | mount | 231 | 238 | 2 | |
| GroupedListV2 | virtual-rerender | 218 | 211 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 224 | 243 | 2 | |
| IconButton | mount | 1140 | 1131 | 5000 | |
| Label | mount | 339 | 333 | 5000 | |
| Layer | mount | 2782 | 2734 | 5000 | |
| Link | mount | 390 | 390 | 5000 | |
| MenuButton | mount | 978 | 993 | 5000 | |
| MessageBar | mount | 21257 | 21270 | 5000 | |
| Nav | mount | 2068 | 2042 | 1000 | |
| OverflowSet | mount | 769 | 796 | 5000 | |
| Panel | mount | 1886 | 1851 | 1000 | |
| Persona | mount | 718 | 757 | 1000 | |
| Pivot | mount | 882 | 898 | 1000 | |
| PrimaryButton | mount | 942 | 910 | 5000 | |
| Rating | mount | 4723 | 4597 | 5000 | |
| SearchBox | mount | 925 | 925 | 5000 | |
| Shimmer | mount | 1894 | 1882 | 5000 | |
| Slider | mount | 1312 | 1352 | 5000 | |
| SpinButton | mount | 2987 | 2932 | 5000 | |
| Spinner | mount | 384 | 396 | 5000 | |
| SplitButton | mount | 1831 | 1880 | 5000 | |
| Stack | mount | 402 | 427 | 5000 | |
| StackWithIntrinsicChildren | mount | 874 | 854 | 5000 | |
| StackWithTextChildren | mount | 2780 | 2816 | 5000 | |
| SwatchColorPicker | mount | 6454 | 6330 | 5000 | |
| TagPicker | mount | 1440 | 1462 | 5000 | |
| Text | mount | 383 | 383 | 5000 | |
| TextField | mount | 939 | 926 | 5000 | |
| ThemeProvider | mount | 865 | 864 | 5000 | |
| ThemeProvider | virtual-rerender | 582 | 574 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1294 | 1296 | 5000 | |
| Toggle | mount | 614 | 597 | 5000 | |
| buttonNative | mount | 195 | 187 | 5000 |
Hotell
reviewed
Jul 18, 2024
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32043 in repo microsoft/fluentui |
Member
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Member
|
Work completed in this PR #31997 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)