Skip to content

ci(vrt): move VRT steps to runpublishvrscreenshot template to reduce duplication#32127

Merged
TristanWatanabe merged 4 commits into
microsoft:masterfrom
TristanWatanabe:tristan/vrt-cleanup
Jul 29, 2024
Merged

ci(vrt): move VRT steps to runpublishvrscreenshot template to reduce duplication#32127
TristanWatanabe merged 4 commits into
microsoft:masterfrom
TristanWatanabe:tristan/vrt-cleanup

Conversation

@TristanWatanabe

@TristanWatanabe TristanWatanabe commented Jul 26, 2024

Copy link
Copy Markdown
Member

Changes:

  • moves create-policy and Run fluentui-screenshotdiff steps to runpublishvrscreenshot template to reduce duplication

Related Issue(s)

@github-actions github-actions Bot added this to the July Project Cycle Q3 2024 milestone Jul 26, 2024
@fabricteam

fabricteam commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam

fabricteam commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 650 645 5000
Button mount 301 311 5000
Field mount 1093 1151 5000
FluentProvider mount 708 717 5000
FluentProviderWithTheme mount 78 89 10
FluentProviderWithTheme virtual-rerender 34 40 10
FluentProviderWithTheme virtual-rerender-with-unmount 75 86 10
MakeStyles mount 889 849 50000
Persona mount 1780 1741 5000
SpinButton mount 1363 1392 5000
SwatchPicker mount 1681 1690 5000

@fabricteam

fabricteam commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam

fabricteam commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 92 80 1.15:1
PortalMinimalPerf.default 95 84 1.13:1
AvatarMinimalPerf.default 121 109 1.11:1
ListWith60ListItems.default 399 361 1.11:1
ButtonMinimalPerf.default 96 87 1.1:1
ButtonSlotsPerf.default 336 307 1.09:1
CardMinimalPerf.default 329 301 1.09:1
ProviderMinimalPerf.default 219 201 1.09:1
ChatDuplicateMessagesPerf.default 158 146 1.08:1
LayoutMinimalPerf.default 213 197 1.08:1
FlexMinimalPerf.default 158 148 1.07:1
RadioGroupMinimalPerf.default 267 251 1.06:1
AttachmentMinimalPerf.default 87 83 1.05:1
LabelMinimalPerf.default 226 216 1.05:1
LoaderMinimalPerf.default 192 183 1.05:1
SliderMinimalPerf.default 755 716 1.05:1
ToolbarMinimalPerf.default 550 523 1.05:1
ChatWithPopoverPerf.default 197 190 1.04:1
FormMinimalPerf.default 227 218 1.04:1
StatusMinimalPerf.default 397 383 1.04:1
DividerMinimalPerf.default 210 204 1.03:1
TooltipMinimalPerf.default 1272 1234 1.03:1
TreeMinimalPerf.default 496 483 1.03:1
HeaderMinimalPerf.default 213 209 1.02:1
PopupMinimalPerf.default 353 347 1.02:1
ProviderMergeThemesPerf.default 671 656 1.02:1
CustomToolbarPrototype.default 1466 1435 1.02:1
VideoMinimalPerf.default 459 452 1.02:1
DialogMinimalPerf.default 442 438 1.01:1
InputMinimalPerf.default 536 533 1.01:1
ItemLayoutMinimalPerf.default 694 689 1.01:1
ListNestedPerf.default 333 329 1.01:1
MenuButtonMinimalPerf.default 966 959 1.01:1
TableManyItemsPerf.default 1097 1082 1.01:1
TableMinimalPerf.default 245 242 1.01:1
AnimationMinimalPerf.default 297 298 1:1
ButtonOverridesMissPerf.default 661 664 1:1
CarouselMinimalPerf.default 258 259 1:1
DatepickerMinimalPerf.default 3646 3648 1:1
DropdownManyItemsPerf.default 392 391 1:1
ListMinimalPerf.default 305 305 1:1
MenuMinimalPerf.default 491 492 1:1
ReactionMinimalPerf.default 216 217 1:1
SkeletonMinimalPerf.default 200 201 1:1
TextMinimalPerf.default 193 193 1:1
TreeWith60ListItems.default 87 87 1:1
AttachmentSlotsPerf.default 643 649 0.99:1
BoxMinimalPerf.default 188 189 0.99:1
CheckboxMinimalPerf.default 1139 1146 0.99:1
DropdownMinimalPerf.default 1426 1437 0.99:1
GridMinimalPerf.default 188 190 0.99:1
RosterPerf.default 1553 1570 0.99:1
HeaderSlotsPerf.default 455 463 0.98:1
ImageMinimalPerf.default 228 233 0.98:1
RefMinimalPerf.default 105 107 0.98:1
SegmentMinimalPerf.default 192 196 0.98:1
SplitButtonMinimalPerf.default 2211 2264 0.98:1
TextAreaMinimalPerf.default 286 293 0.98:1
EmbedMinimalPerf.default 1850 1912 0.97:1
ListCommonPerf.default 393 407 0.97:1
AlertMinimalPerf.default 150 157 0.96:1
IconMinimalPerf.default 370 385 0.96:1
ChatMinimalPerf.default 429 450 0.95:1

@TristanWatanabe TristanWatanabe self-assigned this Jul 26, 2024
@fabricteam

fabricteam commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam

fabricteam commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam

fabricteam commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 642 637 5000
Breadcrumb mount 1662 1688 1000
Checkbox mount 1731 1690 5000
CheckboxBase mount 1487 1484 5000
ChoiceGroup mount 2992 3048 5000
ComboBox mount 686 683 1000
CommandBar mount 6582 6639 1000
ContextualMenu mount 12466 12351 1000
DefaultButton mount 801 816 5000
DetailsRow mount 2233 2213 5000
DetailsRowFast mount 2269 2220 5000
DetailsRowNoStyles mount 2053 1995 5000
Dialog mount 2709 2689 1000
DocumentCardTitle mount 234 237 1000
Dropdown mount 2085 2008 5000
FocusTrapZone mount 1157 1200 5000
FocusZone mount 1086 1063 5000
GroupedList mount 42878 42932 2
GroupedList virtual-rerender 20372 20687 2
GroupedList virtual-rerender-with-unmount 52385 52049 2
GroupedListV2 mount 231 236 2
GroupedListV2 virtual-rerender 211 216 2
GroupedListV2 virtual-rerender-with-unmount 234 234 2
IconButton mount 1151 1129 5000
Label mount 349 343 5000
Layer mount 2721 2768 5000
Link mount 391 404 5000
MenuButton mount 981 998 5000
MessageBar mount 21178 21153 5000
Nav mount 2012 2072 1000
OverflowSet mount 813 774 5000
Panel mount 1836 1881 1000
Persona mount 748 782 1000
Pivot mount 905 899 1000
PrimaryButton mount 940 936 5000
Rating mount 4678 4726 5000
SearchBox mount 935 895 5000
Shimmer mount 1905 1887 5000
Slider mount 1358 1338 5000
SpinButton mount 3004 2982 5000
Spinner mount 412 389 5000
SplitButton mount 1886 1884 5000
Stack mount 428 435 5000
StackWithIntrinsicChildren mount 905 909 5000
StackWithTextChildren mount 2779 2786 5000
SwatchColorPicker mount 6484 6384 5000
TagPicker mount 1444 1469 5000
Text mount 393 396 5000
TextField mount 957 955 5000
ThemeProvider mount 865 856 5000
ThemeProvider virtual-rerender 594 592 5000
ThemeProvider virtual-rerender-with-unmount 1329 1330 5000
Toggle mount 616 609 5000
buttonNative mount 186 190 5000

Comment thread .devops/templates/runpublishvrscreenshot.yml
@TristanWatanabe
TristanWatanabe marked this pull request as ready for review July 26, 2024 19:05
@TristanWatanabe
TristanWatanabe requested a review from a team as a code owner July 26, 2024 19:05
Comment thread azure-pipelines.vrt-pr.yml
@Hotell

Hotell commented Jul 29, 2024

Copy link
Copy Markdown
Contributor

expect(🏅).for(@TristanWatanabe)

image

@TristanWatanabe TristanWatanabe changed the title ci(vrt): move create policy to runpublishvrscreenshot ci(vrt): move VRT steps to runpublishvrscreenshot template to reduce duplication Jul 29, 2024
@TristanWatanabe
TristanWatanabe merged commit d4b3007 into microsoft:master Jul 29, 2024
@TristanWatanabe
TristanWatanabe deleted the tristan/vrt-cleanup branch July 29, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants