fix(workspace-plugin): remove swc-node@register dependency#32254
Merged
Conversation
Hotell
approved these changes
Aug 7, 2024
fabricteam
reviewed
Aug 7, 2024
fabricteam
reviewed
Aug 7, 2024
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 623 | 618 | 5000 | |
| Button | mount | 312 | 295 | 5000 | |
| Field | mount | 1112 | 1143 | 5000 | |
| FluentProvider | mount | 704 | 713 | 5000 | |
| FluentProviderWithTheme | mount | 91 | 86 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 33 | 34 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 71 | 66 | 10 | |
| MakeStyles | mount | 861 | 851 | 50000 | |
| Persona | mount | 1783 | 1714 | 5000 | |
| SpinButton | mount | 1372 | 1401 | 5000 | |
| SwatchPicker | mount | 1675 | 1650 | 5000 |
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| FlexMinimalPerf.default | 164 | 147 | 1.12:1 |
| ChatWithPopoverPerf.default | 204 | 184 | 1.11:1 |
| HeaderMinimalPerf.default | 220 | 200 | 1.1:1 |
| TableMinimalPerf.default | 246 | 225 | 1.09:1 |
| AccordionMinimalPerf.default | 83 | 77 | 1.08:1 |
| AttachmentMinimalPerf.default | 90 | 83 | 1.08:1 |
| LabelMinimalPerf.default | 233 | 216 | 1.08:1 |
| PortalMinimalPerf.default | 90 | 84 | 1.07:1 |
| ProviderMinimalPerf.default | 211 | 197 | 1.07:1 |
| RefMinimalPerf.default | 121 | 113 | 1.07:1 |
| SkeletonMinimalPerf.default | 200 | 187 | 1.07:1 |
| DropdownManyItemsPerf.default | 410 | 387 | 1.06:1 |
| FormMinimalPerf.default | 226 | 213 | 1.06:1 |
| VideoMinimalPerf.default | 464 | 437 | 1.06:1 |
| BoxMinimalPerf.default | 198 | 191 | 1.04:1 |
| LoaderMinimalPerf.default | 197 | 190 | 1.04:1 |
| CardMinimalPerf.default | 313 | 304 | 1.03:1 |
| CarouselMinimalPerf.default | 268 | 260 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 155 | 151 | 1.03:1 |
| ChatMinimalPerf.default | 437 | 424 | 1.03:1 |
| CheckboxMinimalPerf.default | 1168 | 1131 | 1.03:1 |
| EmbedMinimalPerf.default | 1916 | 1858 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 713 | 695 | 1.03:1 |
| MenuMinimalPerf.default | 511 | 497 | 1.03:1 |
| TextAreaMinimalPerf.default | 282 | 274 | 1.03:1 |
| ToolbarMinimalPerf.default | 539 | 523 | 1.03:1 |
| ButtonSlotsPerf.default | 312 | 306 | 1.02:1 |
| DatepickerMinimalPerf.default | 3641 | 3560 | 1.02:1 |
| DropdownMinimalPerf.default | 1452 | 1424 | 1.02:1 |
| ListMinimalPerf.default | 314 | 307 | 1.02:1 |
| SegmentMinimalPerf.default | 199 | 195 | 1.02:1 |
| SliderMinimalPerf.default | 764 | 751 | 1.02:1 |
| TooltipMinimalPerf.default | 1239 | 1211 | 1.02:1 |
| HeaderSlotsPerf.default | 460 | 455 | 1.01:1 |
| ImageMinimalPerf.default | 223 | 221 | 1.01:1 |
| RadioGroupMinimalPerf.default | 258 | 255 | 1.01:1 |
| ReactionMinimalPerf.default | 209 | 206 | 1.01:1 |
| TreeMinimalPerf.default | 477 | 471 | 1.01:1 |
| ListCommonPerf.default | 389 | 390 | 1:1 |
| ListNestedPerf.default | 307 | 307 | 1:1 |
| PopupMinimalPerf.default | 347 | 347 | 1:1 |
| TableManyItemsPerf.default | 1107 | 1112 | 1:1 |
| CustomToolbarPrototype.default | 1468 | 1466 | 1:1 |
| AttachmentSlotsPerf.default | 644 | 653 | 0.99:1 |
| ButtonMinimalPerf.default | 84 | 85 | 0.99:1 |
| DialogMinimalPerf.default | 439 | 442 | 0.99:1 |
| MenuButtonMinimalPerf.default | 942 | 953 | 0.99:1 |
| RosterPerf.default | 1571 | 1583 | 0.99:1 |
| InputMinimalPerf.default | 509 | 519 | 0.98:1 |
| ProviderMergeThemesPerf.default | 635 | 645 | 0.98:1 |
| IconMinimalPerf.default | 385 | 391 | 0.98:1 |
| AlertMinimalPerf.default | 155 | 159 | 0.97:1 |
| AnimationMinimalPerf.default | 300 | 310 | 0.97:1 |
| ButtonOverridesMissPerf.default | 667 | 685 | 0.97:1 |
| LayoutMinimalPerf.default | 193 | 198 | 0.97:1 |
| SplitButtonMinimalPerf.default | 2216 | 2282 | 0.97:1 |
| StatusMinimalPerf.default | 373 | 386 | 0.97:1 |
| TreeWith60ListItems.default | 88 | 91 | 0.97:1 |
| DividerMinimalPerf.default | 199 | 207 | 0.96:1 |
| GridMinimalPerf.default | 181 | 190 | 0.95:1 |
| ListWith60ListItems.default | 355 | 372 | 0.95:1 |
| TextMinimalPerf.default | 191 | 212 | 0.9:1 |
| AvatarMinimalPerf.default | 95 | 112 | 0.85:1 |
fabricteam
reviewed
Aug 7, 2024
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 635 | 627 | 5000 | |
| Breadcrumb | mount | 1704 | 1709 | 1000 | |
| Checkbox | mount | 1666 | 1699 | 5000 | |
| CheckboxBase | mount | 1506 | 1525 | 5000 | |
| ChoiceGroup | mount | 3005 | 2993 | 5000 | |
| ComboBox | mount | 686 | 681 | 1000 | |
| CommandBar | mount | 6605 | 6588 | 1000 | |
| ContextualMenu | mount | 13728 | 13610 | 1000 | |
| DefaultButton | mount | 797 | 825 | 5000 | |
| DetailsRow | mount | 2256 | 2208 | 5000 | |
| DetailsRowFast | mount | 2229 | 2180 | 5000 | |
| DetailsRowNoStyles | mount | 2055 | 2044 | 5000 | |
| Dialog | mount | 2737 | 2824 | 1000 | |
| DocumentCardTitle | mount | 239 | 251 | 1000 | |
| Dropdown | mount | 2008 | 1990 | 5000 | |
| FocusTrapZone | mount | 1128 | 1130 | 5000 | |
| FocusZone | mount | 1083 | 1085 | 5000 | |
| GroupedList | mount | 38342 | 43081 | 2 | |
| GroupedList | virtual-rerender | 20435 | 20421 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 52256 | 52275 | 2 | |
| GroupedListV2 | mount | 227 | 233 | 2 | |
| GroupedListV2 | virtual-rerender | 214 | 220 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 229 | 237 | 2 | |
| IconButton | mount | 1147 | 1135 | 5000 | |
| Label | mount | 337 | 331 | 5000 | |
| Layer | mount | 2719 | 2819 | 5000 | |
| Link | mount | 386 | 405 | 5000 | |
| MenuButton | mount | 985 | 1016 | 5000 | |
| MessageBar | mount | 21606 | 21426 | 5000 | |
| Nav | mount | 2028 | 2061 | 1000 | |
| OverflowSet | mount | 821 | 795 | 5000 | |
| Panel | mount | 1878 | 1916 | 1000 | |
| Persona | mount | 791 | 773 | 1000 | |
| Pivot | mount | 913 | 936 | 1000 | |
| PrimaryButton | mount | 944 | 931 | 5000 | |
| Rating | mount | 4687 | 4650 | 5000 | |
| SearchBox | mount | 932 | 944 | 5000 | |
| Shimmer | mount | 1905 | 1926 | 5000 | |
| Slider | mount | 1389 | 1383 | 5000 | |
| SpinButton | mount | 2953 | 3004 | 5000 | |
| Spinner | mount | 396 | 400 | 5000 | |
| SplitButton | mount | 1889 | 1872 | 5000 | |
| Stack | mount | 409 | 438 | 5000 | |
| StackWithIntrinsicChildren | mount | 888 | 867 | 5000 | |
| StackWithTextChildren | mount | 2774 | 2773 | 5000 | |
| SwatchColorPicker | mount | 6482 | 6502 | 5000 | |
| TagPicker | mount | 1447 | 1484 | 5000 | |
| Text | mount | 392 | 388 | 5000 | |
| TextField | mount | 948 | 964 | 5000 | |
| ThemeProvider | mount | 871 | 864 | 5000 | |
| ThemeProvider | virtual-rerender | 597 | 580 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1311 | 1343 | 5000 | |
| Toggle | mount | 619 | 633 | 5000 | |
| buttonNative | mount | 194 | 188 | 5000 |
Hotell
enabled auto-merge (squash)
August 7, 2024 15:51
bsunderhus
pushed a commit
to bsunderhus/fluentui
that referenced
this pull request
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
nx workspace-plugin generators are broken because of incompatible swc dependency
New Behavior
Incompatible dependency
@swc-node/registerremoved, nx workspace-plugin generators are working as expectedRelated Issue(s)
@swc-node/registerbroken imports swc-project/swc-node#729