Skip to content

chore: override storybook esbuild version that introduced unwanted duplicates#32256

Merged
Hotell merged 1 commit into
microsoft:masterfrom
Hotell:sb/resolve-unwanted-dups-after-migration-to-v7
Aug 8, 2024
Merged

chore: override storybook esbuild version that introduced unwanted duplicates#32256
Hotell merged 1 commit into
microsoft:masterfrom
Hotell:sb/resolve-unwanted-dups-after-migration-to-v7

Conversation

@Hotell

@Hotell Hotell commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

Previous Behavior

New Behavior

see pr title and code comments

Related Issue(s)

@github-actions github-actions Bot added this to the August Project Cycle Q3 2024 milestone Aug 7, 2024
Comment thread package.json
Comment thread package.json
@Hotell Hotell changed the title chore: override old storybook esbuild that creeps our node_modules for no purpose chore: override storybook esbuild version that creeps our node_modules for no purpose Aug 7, 2024
@Hotell Hotell added dependencies Pull requests that update a dependency file Storybook labels Aug 7, 2024
@fabricteam

Copy link
Copy Markdown
Collaborator

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

Comment thread package.json
@fabricteam

Copy link
Copy Markdown
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 643 651 5000
Button mount 309 297 5000
Field mount 1125 1129 5000
FluentProvider mount 712 731 5000
FluentProviderWithTheme mount 82 91 10
FluentProviderWithTheme virtual-rerender 31 32 10
FluentProviderWithTheme virtual-rerender-with-unmount 74 84 10
MakeStyles mount 881 859 50000
Persona mount 1785 1725 5000
SpinButton mount 1399 1426 5000
SwatchPicker mount 1674 1693 5000

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

✅ No changes found

Comment thread package.json
@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatWithPopoverPerf.default 227 190 1.19:1
ButtonMinimalPerf.default 105 92 1.14:1
AvatarMinimalPerf.default 123 110 1.12:1
PortalMinimalPerf.default 97 88 1.1:1
TreeWith60ListItems.default 100 92 1.09:1
CarouselMinimalPerf.default 284 264 1.08:1
InputMinimalPerf.default 582 539 1.08:1
AttachmentMinimalPerf.default 90 84 1.07:1
ListMinimalPerf.default 333 312 1.07:1
BoxMinimalPerf.default 217 205 1.06:1
ChatMinimalPerf.default 480 451 1.06:1
TextMinimalPerf.default 204 193 1.06:1
ButtonOverridesMissPerf.default 710 679 1.05:1
GridMinimalPerf.default 206 196 1.05:1
SegmentMinimalPerf.default 205 196 1.05:1
SplitButtonMinimalPerf.default 2434 2325 1.05:1
DropdownManyItemsPerf.default 415 400 1.04:1
LoaderMinimalPerf.default 200 192 1.04:1
ProviderMergeThemesPerf.default 696 674 1.03:1
ReactionMinimalPerf.default 225 219 1.03:1
StatusMinimalPerf.default 415 404 1.03:1
TableMinimalPerf.default 244 237 1.03:1
DatepickerMinimalPerf.default 4075 4003 1.02:1
DropdownMinimalPerf.default 1509 1481 1.02:1
FormMinimalPerf.default 231 227 1.02:1
LayoutMinimalPerf.default 205 201 1.02:1
ListCommonPerf.default 396 389 1.02:1
ListNestedPerf.default 339 333 1.02:1
CustomToolbarPrototype.default 1655 1616 1.02:1
ToolbarMinimalPerf.default 594 582 1.02:1
AlertMinimalPerf.default 168 166 1.01:1
ImageMinimalPerf.default 240 238 1.01:1
MenuMinimalPerf.default 528 525 1.01:1
ProviderMinimalPerf.default 222 220 1.01:1
TooltipMinimalPerf.default 1385 1365 1.01:1
AttachmentSlotsPerf.default 669 670 1:1
CardMinimalPerf.default 322 321 1:1
DialogMinimalPerf.default 464 465 1:1
DividerMinimalPerf.default 211 212 1:1
EmbedMinimalPerf.default 1944 1941 1:1
HeaderMinimalPerf.default 214 214 1:1
MenuButtonMinimalPerf.default 1005 1010 1:1
IconMinimalPerf.default 404 404 1:1
VideoMinimalPerf.default 459 457 1:1
CheckboxMinimalPerf.default 1170 1186 0.99:1
HeaderSlotsPerf.default 481 487 0.99:1
LabelMinimalPerf.default 228 231 0.99:1
RosterPerf.default 1640 1663 0.99:1
PopupMinimalPerf.default 385 388 0.99:1
RefMinimalPerf.default 120 121 0.99:1
SkeletonMinimalPerf.default 211 214 0.99:1
SliderMinimalPerf.default 794 800 0.99:1
TextAreaMinimalPerf.default 297 301 0.99:1
TreeMinimalPerf.default 494 499 0.99:1
FlexMinimalPerf.default 148 151 0.98:1
ItemLayoutMinimalPerf.default 720 732 0.98:1
AnimationMinimalPerf.default 310 321 0.97:1
ListWith60ListItems.default 381 393 0.97:1
ButtonSlotsPerf.default 319 334 0.96:1
TableManyItemsPerf.default 1130 1172 0.96:1
AccordionMinimalPerf.default 81 87 0.93:1
ChatDuplicateMessagesPerf.default 158 172 0.92:1
RadioGroupMinimalPerf.default 268 290 0.92:1

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 628 621 5000
Breadcrumb mount 1698 1702 1000
Checkbox mount 1711 1714 5000
CheckboxBase mount 1492 1477 5000
ChoiceGroup mount 2971 3054 5000
ComboBox mount 695 697 1000
CommandBar mount 6616 6683 1000
ContextualMenu mount 13743 12966 1000
DefaultButton mount 796 795 5000
DetailsRow mount 2188 2250 5000
DetailsRowFast mount 2272 2257 5000
DetailsRowNoStyles mount 2041 2033 5000
Dialog mount 2871 2738 1000
DocumentCardTitle mount 247 224 1000
Dropdown mount 2009 2028 5000
FocusTrapZone mount 1146 1163 5000
FocusZone mount 1095 1077 5000
GroupedList mount 42598 42887 2
GroupedList virtual-rerender 18360 20569 2
GroupedList virtual-rerender-with-unmount 53163 52503 2
GroupedListV2 mount 240 231 2
GroupedListV2 virtual-rerender 223 235 2
GroupedListV2 virtual-rerender-with-unmount 222 253 2
IconButton mount 1151 1146 5000
Label mount 361 351 5000
Layer mount 2742 2727 5000
Link mount 400 400 5000
MenuButton mount 981 989 5000
MessageBar mount 21541 21578 5000
Nav mount 2050 2096 1000
OverflowSet mount 808 820 5000
Panel mount 1903 1811 1000
Persona mount 780 767 1000
Pivot mount 906 914 1000
PrimaryButton mount 924 948 5000
Rating mount 4737 4729 5000
SearchBox mount 939 948 5000
Shimmer mount 1924 1880 5000
Slider mount 1354 1363 5000
SpinButton mount 3013 3016 5000
Spinner mount 390 395 5000
SplitButton mount 1881 1911 5000
Stack mount 424 427 5000
StackWithIntrinsicChildren mount 891 889 5000
StackWithTextChildren mount 2815 2783 5000
SwatchColorPicker mount 6365 6386 5000
TagPicker mount 1450 1525 5000
Text mount 404 391 5000
TextField mount 931 967 5000
ThemeProvider mount 865 875 5000
ThemeProvider virtual-rerender 585 591 5000
ThemeProvider virtual-rerender-with-unmount 1318 1336 5000
Toggle mount 604 612 5000
buttonNative mount 198 203 5000

@Hotell
Hotell marked this pull request as ready for review August 7, 2024 16:44
@Hotell
Hotell requested a review from a team as a code owner August 7, 2024 16:44
@Hotell
Hotell requested a review from dmytrokirpa August 7, 2024 16:45
@Hotell Hotell changed the title chore: override storybook esbuild version that creeps our node_modules for no purpose chore: override storybook esbuild version that introduced unwanted duplicates Aug 8, 2024
@Hotell
Hotell merged commit c5f2c9f into microsoft:master Aug 8, 2024
@Hotell
Hotell deleted the sb/resolve-unwanted-dups-after-migration-to-v7 branch August 8, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Storybook

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants