fix(babel-preset-storybook-full-source): use named exports for story detection

[dmytrokirpa]

Previous Behavior

After the SB7 migration, a regression occurred where the Positioning Components page is not functioning correctly. This issue arises because the PositionedComponent is defined prior to the story component, leading the babel-full-source-plugin to mistakenly treat it as a story component.

New Behavior

The babel-plugin-full-source detects stories as React components that are exported using named exports.

Related Issue(s)

• introduced at chore: migrate to storybook v7 #32018

[fabricteam]

📊 Bundle size report

✅ No changes found

[Hotell]

IMO the proposed solution won't scale and tries to assume things that will not be clear to follow.

Instead we should update the AST traversal within the plugin to process only storybook components, which AFAIR are only those that are exported ( with optionally containing storybook specific static property assigments ) and live in *.stories.tsx? files.

thoughts?

[dmytrokirpa]

IMO the proposed solution won't scale and tries to assume things that will not be clear to follow.

Instead we should update the AST traversal within the plugin to process only storybook components, which AFAIR are only those that are exported ( with optionally containing storybook specific static property assigments ) and live in *.stories.tsx? files.

thoughts?

The suggestion will work if we'd use babel plugin before any other transformers like SWC. In our case we use SWC to transform TS, JSX and imports, and babel plugin transforms source without those.

[Hotell]

The suggestion will work if we'd use babel plugin before any other transformers like SWC. In our case we use SWC to transform TS, JSX and imports, and babel plugin transforms source without those.

hmm not sure I follow ?

• AFAIR we needed to switch to use unshift in order to make our babel-plugin work during migration
• why would we need TS,JSX and imports ? swc will produce ES6 output ( target: 'es2019',) so exports will be there following the same syntax

[dmytrokirpa]

AFAIR we needed to switch to use unshift in order to make our babel-plugin work during migration
That doesn't help with the babel's inputSourceMap string issue

why would we need TS,JSX and imports ? swc will produce ES6 output ( target: 'es2019',) so exports will be there following the same syntax

That's actually correct, exports are available at the time when babel transforms stories. I've updated the plugin to use named exports. Thank you for the suggestion!

[Hotell]

1 actionable and 1 question. beside that great job !