fix(public-docsite-v9): subcomponents prop docs are not visible on docsite#32382
Merged
dmytrokirpa merged 2 commits intoAug 26, 2024
Merged
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
Hotell
reviewed
Aug 26, 2024
Hotell
approved these changes
Aug 26, 2024
dmytrokirpa
changed the title
This was referenced Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
During the migration to #32018, as per migration guide, we replaced
<ArgTable />with<ArgTypes />. However, this has led to an issue where does not support subcomponents, preventing their prop documentation from being displayed on the documentation site.New Behavior
The properties of subcomponents are accessible on the documentation site:
The proposed solution is to switch back to the ArgsTable as it's still available in Storybook v7, and switch to ArgTypes after migration to Storybook v8, where subcomponents support are in place.
Related Issue(s)