docs(docs-site): add motion components page #32437
Merged
mainframev merged 15 commits intoSep 29, 2024
Merged
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
mainframev
force-pushed
the
docs/extend-dialog-storybook-examples
branch
2 times, most recently
from
September 2, 2024 22:23
7685621 to
136bbac
Compare
mainframev
marked this pull request as ready for review
September 2, 2024 22:23
mainframev
force-pushed
the
docs/extend-dialog-storybook-examples
branch
from
September 3, 2024 09:17
136bbac to
c92e778
Compare
layershifter
requested changes
Sep 3, 2024
layershifter
left a comment
layershifter
left a comment
Member
There was a problem hiding this comment.
See #32411 (comment).
IMO adding examples for the same concept across components - does not scale 🥲
We should have a shared documentation page that explains how customize/disable motion (see docs for positioning) and link to it components that are using it.
Contributor
Author
@layershifter makes sense. Should I create a separate request for it or can do within current? wdyt? |
microsoft-github-policy-service
Bot
added
Needs: Attention
and removed
Needs: Author Feedback
labels
Member
Up to you 🐱 |
mainframev
force-pushed
the
docs/extend-dialog-storybook-examples
branch
from
September 6, 2024 19:32
c92e778 to
922d6ee
Compare
mainframev
changed the title
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 635 | 646 | 5000 | |
| Button | mount | 306 | 310 | 5000 | |
| Field | mount | 1139 | 1170 | 5000 | |
| FluentProvider | mount | 723 | 713 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 88 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 33 | 36 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 77 | 10 | |
| MakeStyles | mount | 857 | 878 | 50000 | |
| Persona | mount | 1773 | 1688 | 5000 | |
| SpinButton | mount | 1436 | 1354 | 5000 | |
| SwatchPicker | mount | 1690 | 1694 | 5000 |
fabricteam
reviewed
Sep 6, 2024
mainframev
marked this pull request as draft
September 6, 2024 19:50
layershifter
approved these changes
Sep 23, 2024
added 2 commits
September 23, 2024 16:44
Hotell
reviewed
Sep 24, 2024
…nd createPresenceComponent
mainframev
added
Package: motion
Hotell
reviewed
Sep 26, 2024
Hotell
left a comment
Hotell
left a comment
Contributor
There was a problem hiding this comment.
comments from previous review haven't been addressed
Hotell
reviewed
Sep 27, 2024
Hotell
reviewed
Sep 27, 2024
Hotell
approved these changes
Sep 27, 2024
Hotell
left a comment
Hotell
left a comment
Contributor
There was a problem hiding this comment.
approving to unblock, although please dont forget to:
- please address actionable comments
- regarding the conversion to pure MDX, this will be tackled as a follow up
…112e.json Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
…7cf3.json Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
…es.tsx Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
…es.tsx Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
… separate components
mltejera
pushed a commit
to mltejera/office-ui-fabric-react
that referenced
this pull request
Oct 3, 2024
Co-authored-by: viktorgenaev <viktorgenaev@microsoft.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding additional pages to
react-motionwithmotion slotexamples. AddedhideArgsTabledocs parameter to hideArgsTableblock.Previous Behavior
New Behavior
Added motion components page and links to related components.
Related Issue(s)