Skip to content

fix: make StoryWright steps work in storybook 7 - #33783

Merged
Hotell merged 7 commits into
microsoft:masterfrom
Hotell:vrt/make-storwright-steps-work
Feb 12, 2025
Merged

fix: make StoryWright steps work in storybook 7#33783
Hotell merged 7 commits into
microsoft:masterfrom
Hotell:vrt/make-storwright-steps-work

Conversation

@Hotell

@Hotell Hotell commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

Previous Behavior

New Behavior

  • removes invalid testWrapper selector for stories that don'd render this wrapper via decorator or programmatically
  • this fix adds VR tests that were non-existent for 6+ months so the change is big
image

action for story owners 👋:

  1. Please adjust your VR stories accordingly with appropriate wrappers that can be found here: https://github.com/microsoft/fluentui/blob/master/apps/vr-tests-react-components/src/utilities/TestWrapperDecorator.tsx
  1. Fix invalid Steps using executeScripts
  • disables storybook storyStoreV7 temporarily for vr apps ( which shouldn't be possible but it works)

Related Issue(s)

@Hotell Hotell changed the title Vrt/make storwright steps work fix: make StoryWright steps work in storybook 7 Feb 5, 2025
@github-actions

github-actions Bot commented Feb 5, 2025

Copy link
Copy Markdown

📊 Bundle size report

✅ No changes found

@github-actions

github-actions Bot commented Feb 5, 2025

Copy link
Copy Markdown

Pull request demo site: URL

Comment thread apps/vr-tests-react-components/.storybook/main.js
Comment thread apps/vr-tests-react-components/.storybook/main.js
Comment thread apps/vr-tests-react-components/.storybook/main.js
@Hotell
Hotell marked this pull request as ready for review February 5, 2025 16:31
@Hotell
Hotell requested review from a team as code owners February 5, 2025 16:31
@Hotell
Hotell requested review from a team February 6, 2025 15:23
@dmytrokirpa

dmytrokirpa commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

Hey @Hotell, great findings! I have a suggestion - rather than adjusting steps to remove the .testWrapper selector, why not add the TestWrapper decorator to the stories that don't have it? This will make future TestWrapper unification easier #31994.

What do you think?

@Hotell

Hotell commented Feb 7, 2025

Copy link
Copy Markdown
Contributor Author

Hey @Hotell, great findings! I have a suggestion - rather than adjusting steps to remove the .testWrapper selector, why not add the TestWrapper decorator to the stories that don't have it? This will make future TestWrapper unification easier #31994.

What do you think?

yeah that was my original intent, but I don't have context to do that with expected outcome -> thus the call to action to test authors within PR description

image

to add on this, this appears to be bigger issues in general right

  • no generators to create VR test/no docs = inconsistency everywhere
  • the tool wont fail if invalid cropTo to is provided = needs feature work on StoryWright or we can build lint rules
  • high probability to migrate away from storywright = big effort

@Hotell

Hotell commented Feb 11, 2025

Copy link
Copy Markdown
Contributor Author

@chrisdholt can we get approval from your crew please ?

@marchbox marchbox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for vr-tests-web-components

@Hotell
Hotell merged commit 780620e into microsoft:master Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: No VR interactive test steps are being executed

6 participants