Semantic Tokens - #33831
Closed
Mitch-At-Work wants to merge 12 commits into
Closed
Conversation
Contributor
Author
|
Todo:
|
Mitch-At-Work
commented
Feb 12, 2025
| "@fluentui/react-shared-contexts": "^9.21.2", | ||
| "@fluentui/react-tabster": "^9.23.3", | ||
| "@fluentui/react-theme": "^9.1.24", | ||
| "@fluentui/semantic-tokens": "^0.0.0-alpha.1", |
Contributor
Author
There was a problem hiding this comment.
Should we be importing this via react-theme for Fluentui component usage?
Contributor
There was a problem hiding this comment.
like re-export through the react-theme package? I think the less we tangle dependencies the better IMHO.
|
Pull request demo site: URL |
| "@fluentui/scripts-api-extractor": "*" | ||
| }, | ||
| "dependencies": { | ||
| "@swc/helpers": "^0.5.1", |
Contributor
There was a problem hiding this comment.
Do we actually need this as a dep vs a devdep?
Contributor
Author
There was a problem hiding this comment.
Not 100% certain but following the same dependency schema as our other top level packages here
Mitch-At-Work
force-pushed
the
user/mifraser/semantic-token-package
branch
from
February 19, 2025 17:18
7d5e1fb to
b4c5a56
Compare
| @@ -272,6 +272,7 @@ packages/react-components/react-virtualizer/stories @microsoft/xc-uxe @Mitch-At- | |||
| packages/react-components/react-skeleton/library @microsoft/cxe-prg | |||
Collaborator
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report
Accordion 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Accordion. - Dark Mode.normal.chromium_1.png | 2660 | Changed |
Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar. - Dark Mode.normal.chromium.png | 10569 | Changed |
Switch 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Switch. - Dark Mode.hover.chromium_2.png | 92 | Changed |
| Switch. - Dark Mode.normal.chromium_1.png | 92 | Changed |
📊 Bundle size report
Unchanged fixtures
|
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Mitch-At-Work
force-pushed
the
user/mifraser/semantic-token-package
branch
from
February 20, 2025 22:37
2b7463b to
22b1d58
Compare
Mitch-At-Work
force-pushed
the
user/mifraser/semantic-token-package
branch
from
February 24, 2025 17:45
6ee8605 to
1d6d672
Compare
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
| export const ctrlLinkForegroundBrandHover: string; | ||
|
|
||
| // @public (undocumented) | ||
| export const ctrlLinkForegroundBrandHoverRaw = "--ctrl-link-foreground-brand-hover"; |
Contributor
There was a problem hiding this comment.
We shipped prefixing our tokens with --smtc-, we shoudl probably align on that.
Contributor
Author
There was a problem hiding this comment.
I'm a little concerned this isn't matching the JSON I've received, it's easy enough for us to add but need to be sure we are all synced on this - can discuss this at our meeting today.
|
|
||
| // Text | ||
| export const textStyleDefaultRegularFontfamily = `var(--text-style-default-regular-fontfamily, ${tokens.fontFamilyBase})`; | ||
| export const textGlobalBody3Fontsize = `var(--text-global-body3-fontsize, ${tokens.fontSizeBase300})`; |
Contributor
There was a problem hiding this comment.
Will need a system for layering in optional tokens.
Contributor
Author
There was a problem hiding this comment.
My understanding is that these tokens do not have an optional token layer, based on the JSON I recieved - we can add multiple layers if needed, but not sure we want multiple layers of optional tokens if not needed (for optimized bundle size) and some of these tokens are provided as component level tokens which will have an additional component-specific targeted CSSVar.
Consuming users can override '--text-style-default-regular-fontfamily' if looking to replace any preconfigured CSS vars (but in Fluent 2 this will be null and resolve to existing tokens.fontFamilyBase).
Contributor
There was a problem hiding this comment.
One thing to call out is that sometimes, the value is a calc function trying to coerce a value out of two F2 variables or maybe just a random static value that's unvariablized. But those values will be available as a single semantic token. So there are times where a token value might look more like...
export const someToken = `var(--someToken, calc(${tokens.somef2token} + ${tokens.someOtherF2Token}))`;I think we only have a couple instances where this happens. If values like this in your exports (which is totally normal), you end up having to create an internal variable in the component to resolve it. I'd have to take a deeper look but it's also possible your *Raw variable exports are a better workaround for this scenario.
Contributor
Author
|
Closing in favor of: #33931 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: This is a proof of concept draft only (for now).
Previous Behavior
Tokens provided a direct token -> CSS variable link
New Behavior
New semantic-tokens top level library
Tokens are now semantically enabled, providing options for fallbacks and component-level styling.