Skip to content

fix(vr-tests-react-components): make sure build-storybook has all deps build assets before it runs - #33851

Merged
Hotell merged 1 commit into
microsoft:masterfrom
Hotell:vrt/fix-build-step
Feb 20, 2025
Merged

fix(vr-tests-react-components): make sure build-storybook has all deps build assets before it runs#33851
Hotell merged 1 commit into
microsoft:masterfrom
Hotell:vrt/fix-build-step

Conversation

@Hotell

@Hotell Hotell commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

Previous Behavior

New Behavior

workspace SB addon are transpiled and consumed as expected within production storybook build that is served to storywright

Related Issue(s)

Comment thread apps/vr-tests-react-components/.storybook/main.js
@github-actions

github-actions Bot commented Feb 17, 2025

Copy link
Copy Markdown

📊 Bundle size report

✅ No changes found

Comment thread apps/vr-tests-react-components/.storybook/main.js
@github-actions

Copy link
Copy Markdown

Pull request demo site: URL

Comment thread apps/vr-tests-react-components/.storybook/main.js
Comment thread apps/vr-tests-react-components/.storybook/main.js
@Hotell
Hotell force-pushed the vrt/fix-build-step branch from bc69f28 to f47168e Compare February 19, 2025 08:46
@Hotell Hotell changed the title Vrt/fix build step fix(vr-tests-react-components): make sure build-storybook has all deps build assets before it runs Feb 19, 2025
@Hotell Hotell added dependencies Pull requests that update a dependency file Storybook Area: Storywright labels Feb 19, 2025
Comment thread apps/vr-tests-react-components/package.json
@Hotell
Hotell marked this pull request as ready for review February 19, 2025 09:35
@Hotell
Hotell requested review from a team as code owners February 19, 2025 09:35
@Hotell
Hotell merged commit 35637c4 into microsoft:master Feb 20, 2025
@Hotell
Hotell deleted the vrt/fix-build-step branch February 20, 2025 10:06
mainframev pushed a commit to mainframev/fluentui that referenced this pull request Jun 9, 2025
tudorpopams pushed a commit to tudorpopams/fluentui that referenced this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Storywright dependencies Pull requests that update a dependency file NX: core Storybook

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants