Semantic-tokens: Flat export deprecated tokens (Tree shakability in ESBuild) - #34235
Merged
Mitch-At-Work merged 6 commits intoApr 14, 2025
Conversation
|
Pull request demo site: URL |
Mitch-At-Work
marked this pull request as ready for review
April 11, 2025 20:28
Mitch-At-Work
force-pushed
the
user/mifraser/add-legacy-script
branch
from
April 14, 2025 16:30
783d7b5 to
e082fc0
Compare
brandonthomas
requested changes
Apr 14, 2025
brandonthomas
left a comment
brandonthomas
left a comment
Contributor
There was a problem hiding this comment.
I think we need to update the legacyTokens.ts script to ensure if the values of the tokens change we account for that vs assuming the delcaration name and value always match.
brandonthomas
approved these changes
Apr 14, 2025
Mitch-At-Work
added a commit
that referenced
this pull request
Apr 28, 2025
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 6, 2025
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Currently, webpack tree shakes fluentui/tokens package, however, ESBuild does not.
New Behavior
By flat exporting the deprecated fallback tokens, we ensure that any direct imports of fluentui/semantic-tokens will be tree shaken by default in all build systems.