Semantic Tokens: Progress Bar - #34403
Merged
Mitch-At-Work merged 4 commits intoMay 14, 2025
Merged
Conversation
|
Pull request demo site: URL |
Mitch-At-Work
requested changes
May 8, 2025
Mitch-At-Work
left a comment
Mitch-At-Work
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Let's make sure we capture the height tokens also (i.e. ctrlProgressHeightEmpty/Filled and their size variants) with rawValue fallbacks
microsoft-github-policy-service
Bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Mitch-At-Work
self-requested a review
May 13, 2025 17:12
Marcos Moura (marcosmoura)
approved these changes
May 14, 2025
Mitch-At-Work
force-pushed
the
xuehua/progress-bar
branch
from
May 14, 2025 18:08
fbe46f7 to
153fec4
Compare
Mitch-At-Work
approved these changes
May 14, 2025
Mitch-At-Work
left a comment
Mitch-At-Work
left a comment
Contributor
There was a problem hiding this comment.
Should be rebased on latest base branch changes and good to go!
Mitch-At-Work
enabled auto-merge (squash)
May 14, 2025 18:29
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 6, 2025
Co-authored-by: Mitch-At-Work <mifraser@microsoft.com>
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 20, 2025
Co-authored-by: Mitch-At-Work <mifraser@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No visual regression
This pull request introduces a new feature for a Progress Bar component in
@fluentui/react-progressand refactors the styling system to use semantic tokens for improved consistency and maintainability. The most important changes include the addition of the Progress Bar feature, updates to the styling definitions to replace hardcoded values with semantic tokens, and the extension of the semantic tokens library to support these changes.New Feature:
@fluentui/react-progress.Styling Refactor:
useProgressBarStyles.styles.tsto replace hardcoded token values with semantic tokens for properties likebackgroundColorandborderRadius, ensuring consistency across themes. [1] [2] [3] [4]useProgressBarStyles.styles.tsto align with the new design token strategy.Semantic Tokens Enhancements:
fluentOverrides.tswith new semantic tokens such asctrlProgressBackgroundEmpty,ctrlProgressBackgroundFilled, andstatusSuccessBackground, mapping them to existing design tokens.tokens.tsandcontrol/tokens.tsto provide fallback values for new semantic tokens, ensuring compatibility with legacy tokens. [1] [2] [3]colorNeutralBackground6,colorCompoundBrandBackground, andborderRadiusMediumtolegacy/tokens.tsfor broader usage.