Extended-tokens: Update to latest JSON spec and fix camel casing - #34439
Merged
Mitch-At-Work merged 7 commits intoMay 14, 2025
Merged
Conversation
|
Pull request demo site: URL |
Mitch-At-Work
marked this pull request as ready for review
May 13, 2025 23:20
brandonthomas
approved these changes
May 14, 2025
brandonthomas
left a comment
brandonthomas
left a comment
Contributor
There was a problem hiding this comment.
Looks good, only thing is we need unit tests around this both to safe guard from name changes we import from Figma or configuration issues on our end.
Marcos Moura (marcosmoura)
approved these changes
May 14, 2025
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 6, 2025
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Token names were lowercased and then camelcased
New Behavior
Token casing is now important to keep, lowercase two unique scenarios (all caps)
fluentOverrides.ts now moved to src/fallbacks/fluentOverrides.ts
We now enforce alphebetical JSON key sort via linter to simplify merge conflicts
Update already merged token names that changed due to camel case update