Extended-tokens: Fix regressions from new JSON refactor - #34458
Merged
Mitch-At-Work merged 1 commit intoMay 15, 2025
Merged
Conversation
Mitch-At-Work
marked this pull request as ready for review
May 15, 2025 17:35
Xue (etudie)
approved these changes
May 15, 2025
|
Pull request demo site: URL |
Mitch-At-Work
enabled auto-merge (squash)
May 15, 2025 17:46
Mitch-At-Work
force-pushed
the
user/mifraser/fix-script-changes
branch
from
May 15, 2025 17:56
a32f18f to
1b69a2d
Compare
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 6, 2025
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
NULL was skipped originally, but new casing sensitivity prevented us from catching null tokens
New Behavior
Now remove null tokens
We also ignore 'unset' for any tokens with proper fallbacks in place.
Updated link to use the correct focus token