Skip to content

Extended Tokens: Input - #34796

Merged
Mitch-At-Work merged 8 commits into
microsoft:extended-tokensfrom
etudie:xuehua/input
Jul 16, 2025
Merged

Extended Tokens: Input#34796
Mitch-At-Work merged 8 commits into
microsoft:extended-tokensfrom
etudie:xuehua/input

Conversation

@etudie

Copy link
Copy Markdown

This pull request introduces updates to the @fluentui/react-input package, focusing on replacing hardcoded tokens with semanticTokens for styling consistency and adding new semantic token definitions. These changes aim to improve maintainability and alignment with design specifications.

Updates to @fluentui/react-input styling:

  • Replaced tokens with semanticTokens in useInputStyles.styles.ts for properties like borderRadius, backgroundColor, borderColor, and color, ensuring a more consistent and semantic approach to styling. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Dependency and token updates:

  • Added @fluentui/semantic-tokens as a dependency in package.json to support the use of semantic tokens.
  • Introduced a new semantic token foregroundCtrlIconOnNeutralRest in semantic-tokens and updated its fallback value to include colorNeutralForeground3. [1] [2] [3]

Changelog:

  • Added a changelog entry for the @fluentui/react-input package to document the minor update and its impact on dependent packages.

@Mitch-At-Work

Copy link
Copy Markdown
Contributor

Looks like we'll need to account for the corner radius similar to textArea here:
image

@Mitch-At-Work

Copy link
Copy Markdown
Contributor

Looks like both pressed (active) and selected (focus-within) states use the same color for the colored bottom border bar, but they should have alternate states based on original spec, let's review those and ensure that pressed takes priority and has it's legacy color enabled (+ pressed semantic token)

@Mitch-At-Work Mitch-At-Work left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks required on the bottom bar

@etudie

Copy link
Copy Markdown
Author
image

Updated border

Can you clarify on this? I'll reach out. Thanks! Mitch-At-Work

Looks like both pressed (active) and selected (focus-within) states use the same color for the colored bottom border bar, but they should have alternate states based on original spec, let's review those and ensure that pressed takes priority and has it's legacy color enabled (+ pressed semantic token)

@github-actions

Copy link
Copy Markdown

Pull request demo site: URL

@Mitch-At-Work
Mitch-At-Work merged commit 54c547a into microsoft:extended-tokens Jul 16, 2025
10 of 14 checks passed
Mitch-At-Work added a commit that referenced this pull request Aug 6, 2025
Co-authored-by: Mitch-At-Work <mifraser@microsoft.com>
Mitch-At-Work added a commit that referenced this pull request Aug 20, 2025
Co-authored-by: Mitch-At-Work <mifraser@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants