Extended Tokens: Search - #34842
Merged
Merged
Conversation
|
Pull request demo site: URL |
Mitch-At-Work
requested changes
Jul 17, 2025
Mitch-At-Work
left a comment
Mitch-At-Work
left a comment
Contributor
There was a problem hiding this comment.
Can we also take a look at the padding/spacing tokens here? We might not be able to replace all, but is there some that can be updated for now with what's available?
microsoft-github-policy-service
Bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Mitch-At-Work
force-pushed
the
xuehua/search
branch
2 times, most recently
from
July 23, 2025 23:04
969b278 to
4dda61d
Compare
Mitch-At-Work
force-pushed
the
xuehua/search
branch
from
July 23, 2025 23:07
4dda61d to
d6358aa
Compare
Mitch-At-Work
approved these changes
Jul 23, 2025
Mitch-At-Work
left a comment
Mitch-At-Work
left a comment
Contributor
There was a problem hiding this comment.
Trying to figure out why we're having yarn lock issues in this PR and not others - otherwise looks good to go.
Contributor
|
Ah! Search should be v 9.1.6 - resolved |
Mitch-At-Work
force-pushed
the
xuehua/search
branch
from
July 23, 2025 23:38
20e02a3 to
6cc9cef
Compare
Mitch-At-Work
enabled auto-merge (squash)
July 23, 2025 23:38
Mitch-At-Work
merged commit Jul 23, 2025
f7b8e4c
into
microsoft:extended-tokens
10 of 14 checks passed
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 6, 2025
Co-authored-by: Mitch-At-Work <mifraser@microsoft.com>
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 20, 2025
Co-authored-by: Mitch-At-Work <mifraser@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new set of semantic styles for the
SearchBoxcomponent, enabling consistent and customizable styling across different states and sizes. The changes include the creation of a dedicated styling file, integration of the new styles into the semantic style hooks registry, and updates to the exports for better accessibility.Addition of
SearchBoxsemantic styles:packages/react-components/semantic-style-hooks-preview/library/src/component-styles/Search/useSemanticSearchStyles.styles.ts: Added a comprehensive set of styles for theSearchBoxcomponent, including support for different sizes (small,medium,large) and states (focused,disabled). These styles utilize Fluent UI tokens and semantic tokens for consistency.Integration into the semantic style hooks registry:
packages/react-components/semantic-style-hooks-preview/library/src/component-styles/semanticStyleHooks.ts: Registered theuseSemanticSearchBoxStylesfunction under theSEMANTIC_STYLE_HOOKSobject, making it accessible for use across the application.Export updates:
packages/react-components/semantic-style-hooks-preview/library/src/component-styles/Search/index.ts: Added an export foruseSemanticSearchBoxStylesto allow external access to the newly implemented styles.packages/react-components/semantic-style-hooks-preview/library/src/component-styles/semanticStyleHooks.ts: Included theuseSemanticSearchBoxStylesimport to ensure it is properly linked within the semantic style hooks file.