Semantic Tokens: Tooltip - #34845
Merged
Mason Tejera (mltejera) merged 6 commits intoJul 17, 2025
Merged
Conversation
terynk
reviewed
Jul 16, 2025
Mason Tejera (mltejera)
force-pushed
the
extended-tokenss/matejera/tool-tip
branch
from
July 16, 2025 17:18
b5c8dfb to
42e3cf3
Compare
|
Looks great, possibly missing the build commit? |
|
Pull request demo site: URL |
Mitch-At-Work
approved these changes
Jul 17, 2025
Mason Tejera (mltejera)
force-pushed
the
extended-tokenss/matejera/tool-tip
branch
from
July 17, 2025 20:40
2e6924b to
d53f51b
Compare
Mason Tejera (mltejera)
merged commit Jul 17, 2025
54dc2e6
into
extended-tokens
13 of 17 checks passed
Mitch-At-Work
pushed a commit
that referenced
this pull request
Aug 6, 2025
Mitch-At-Work
pushed a commit
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes include adding new tooltip styles, integrating them into the semantic style hooks, and simplifying semantic token definitions by removing redundant values and unused tokens.
Tooltip Integration and Styles:
packages/react-components/semantic-style-hooks-preview/library/package.json: Added@fluentui/react-tooltipas a dependency to support tooltip styling.packages/react-components/semantic-style-hooks-preview/library/src/component-styles/Tooltip/index.ts: Exported the newuseSemanticTooltipStylesfunction for tooltip styling.packages/react-components/semantic-style-hooks-preview/library/src/component-styles/Tooltip/useSemanticTooltipStyles.styles.ts: Implemented semantic tooltip styles using@griffel/reactand semantic tokens, including support for inverted appearance.packages/react-components/semantic-style-hooks-preview/library/src/component-styles/semanticStyleHooks.ts: IntegrateduseSemanticTooltipStylesinto the semantic style hooks for consistent tooltip styling. [1] [2]Semantic Token Refinements:
packages/semantic-tokens/etc/semantic-tokens.api.md: Simplified token definitions by removing fallback values and unused tokens. For example, tokens likecornerCtrlHoverandctrlDialogBaseShadownow rely solely on primary semantic tokens, and unused checkbox-related tokens were removed. [1] [2] [3] [4] [5]