Semantic Tokens: Fix classNames order in Avatar and Accordion - #34885
Merged
Mitch-At-Work merged 1 commit intoJul 21, 2025
Merged
Conversation
|
Pull request demo site: URL |
Rachel Yoo (rachethecreator)
approved these changes
Jul 21, 2025
Mitch-At-Work
merged commit Jul 21, 2025
ab4bb48
into
microsoft:extended-tokens
9 of 13 checks passed
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 6, 2025
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
useSemanticAccordionHeaderStylesanduseSemanticAvatarStylesfunctions to ensure that existing class names are preserved when merging styles. The changes improve the consistency and correctness of class name assignments for various components.Changes to Accordion Header Styles:
useSemanticAccordionHeaderStylesinuseSemanticAccordionHeaderStyles.styles.ts: Updated the order ofmergeClassescalls to ensure thatstate.root.className,state.button.className,state.expandIcon.className, andstate.icon.classNameare preserved when merging with other styles. [1] [2]Changes to Avatar Styles:
useSemanticAvatarStylesinuseSemanticAvatarStyles.styles.ts: AdjustedmergeClassescalls forstate.badge.className,state.image.className,state.initials.className, andstate.icon.classNameto include the existing class names before merging additional styles. [1] [2]