add teaching popover to semantic style hooks - #34898
Merged
Mitch-At-Work merged 3 commits intoJul 24, 2025
Merged
Conversation
Rachel Yoo (rachethecreator)
force-pushed
the
ryoo/teaching-popover
branch
from
July 23, 2025 17:50
00eb240 to
9e26e0c
Compare
|
Pull request demo site: URL |
Rachel Yoo (rachethecreator)
force-pushed
the
ryoo/teaching-popover
branch
from
July 23, 2025 20:13
9e26e0c to
c51f1d2
Compare
Mitch-At-Work
approved these changes
Jul 23, 2025
Mitch-At-Work
force-pushed
the
ryoo/teaching-popover
branch
from
July 24, 2025 00:39
c51f1d2 to
89d5191
Compare
Mitch-At-Work
enabled auto-merge (squash)
July 24, 2025 00:39
Mitch-At-Work
merged commit Jul 24, 2025
a4e8061
into
microsoft:extended-tokens
10 of 14 checks passed
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 6, 2025
Co-authored-by: Mitch-At-Work <mifraser@microsoft.com>
Mitch-At-Work
added a commit
that referenced
this pull request
Aug 20, 2025
Co-authored-by: Mitch-At-Work <mifraser@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds react-teaching-popover to semantic-style-hooks-preview
Missing the following semantic tokens in TeachingPopoverHeader--
color: tokens.colorNeutralForeground3- there are semantic token values mapped influentOverridesbut are specific for other components (Avatar, Badge), or for icons (foregroundCtrlIconOnNeutralRest)padding: tokens.spacingVerticalXS/spacingHorizontalXS- there are no equivalents for the vertical spacing token, and the existing horizontal spacing token values mapped influentOverridesare for the Badge component or for gap spacing, not paddingNote: Will need to replace
usePopoverSurfaceStyles_unstablewith localuseSemanticPopoverSurfaceStylesin TeachingPopoverSurface when Popover component is added to semantic style hooks