feat(react-components): move react-alert, react-infobutton, and react-virtualizer to optional peerDependencies#35217
Closed
dmytrokirpa wants to merge 5 commits into
Closed
feat(react-components): move react-alert, react-infobutton, and react-virtualizer to optional peerDependencies#35217dmytrokirpa wants to merge 5 commits into
dmytrokirpa wants to merge 5 commits into
Conversation
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 182 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 892 | Changed |
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Hotell
reviewed
Sep 23, 2025
dmytrokirpa
force-pushed
the
react-19
branch
from
September 23, 2025 07:35
570e528 to
409f401
Compare
…-virtualizer to optional peerDependencies
dmytrokirpa
force-pushed
the
react-19
branch
from
September 23, 2025 07:36
409f401 to
7351805
Compare
Contributor
|
changes LGTM, needs PR description tweaks ( discussed offline ) |
dmytrokirpa
marked this pull request as ready for review
September 24, 2025 14:42
2 tasks
Contributor
Author
|
Closing this in favor of #35285 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves React 19 peer dependency conflicts by moving
@fluentui/react-alert,@fluentui/react-infobutton, and@fluentui/react-virtualizerfrom direct dependencies to optional peer dependencies in the@fluentui/react-componentspackage.Problem
The deprecated packages exported through
/unstablewere causing peer dependency issues wheninstalling
@fluentui/react-componentswith React 19:WARN Issues with peer dependencies found
These packages:
Solution
What Users Need to Do
/unstablecomponents:@fluentui/react-alert,@fluentui/react-infobutton, or@fluentui/react-virtualizer) in your project./unstableexports, as these packages will not resolve peer dependencies with React 19 and manual installs will fail.Benefits
/unstableusersTesting
This change supports the transition strategy for deprecated unstable components while enabling React 19 compatibility.