Skip to content

fix(react-charts): remove redundant styles #35476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anush2303 merged 2 commits into from
Nov 12, 2025
Merged

fix(react-charts): remove redundant styles #35476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d56cf66
remove styles
Nov 11, 2025
b0a841e
Add change file
Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charts-41ce4e16-a576-4864-b71c-f17f6f88e461.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "remove redundant styles",
"packageName": "@fluentui/react-charts",
"email": "anushgupta@microsoft.com",
"dependentChangeType": "patch"
}
2 changes: 0 additions & 2 deletions ...arts/react-charts/library/src/components/CommonComponents/useChartPopoverStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ const useStyles = makeStyles({
calloutContentRoot: {
Comment thread
Anush2303 marked this conversation as resolved.
display: 'grid',
overflow: 'hidden',
// TODO: Confirm this style is needed. Shorthands are not used correctly, therefore this style has no effect.
// ...shorthands.padding('11px 16px 10px 16px'),
backgroundColor: tokens.colorNeutralBackground1,
backgroundBlendMode: 'normal, luminosity',
},
Expand Down
2 changes: 0 additions & 2 deletions packages/charts/react-charts/library/src/components/Legends/useLegendsStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ const useStyles = makeStyles({
whiteSpace: 'nowrap',
width: '100%',
alignItems: 'center',
// TODO: Confirm this style is needed. Shorthands are not used correctly, therefore this style has no effect.
// ...shorthands.margin('-8px 0 0 -8px'),
},
legend: {
// setting display to flex does not work
Expand Down