Skip to content

fix(react-charts): fix incomplete donut and VSBC bug - #35484

Merged
Anush2303 merged 6 commits into
microsoft:masterfrom
Anush2303:usr/agupta/fixBlackSankey
Nov 14, 2025
Merged

fix(react-charts): fix incomplete donut and VSBC bug#35484
Anush2303 merged 6 commits into
microsoft:masterfrom
Anush2303:usr/agupta/fixBlackSankey

Conversation

@Anush2303

@Anush2303 Anush2303 commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

@Anush2303
Anush2303 marked this pull request as ready for review November 13, 2025 04:50
@Anush2303
Anush2303 requested a review from a team as a code owner November 13, 2025 04:50
@github-actions

github-actions Bot commented Nov 13, 2025

Copy link
Copy Markdown

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-charts
DeclarativeChart
718.222 kB
208.001 kB
718.606 kB
208.058 kB
384 B
57 B
react-charts
DonutChart
297.311 kB
88.889 kB
297.339 kB
88.898 kB
28 B
9 B
react-charts
SankeyChart
199.508 kB
61.368 kB
199.518 kB
61.371 kB
10 B
3 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-charts
AreaChart
401.301 kB
122.791 kB
react-charts
FunnelChart
288.594 kB
85.727 kB
react-charts
GanttChart
383.058 kB
115.953 kB
react-charts
GaugeChart
312.216 kB
92.539 kB
react-charts
GroupedVerticalBarChart
390.846 kB
118.496 kB
react-charts
HeatMapChart
385.138 kB
117.661 kB
react-charts
HorizontalBarChart
294.96 kB
86.77 kB
react-charts
HorizontalBarChartWithAxis
63 B
83 B
react-charts
Legends
234.066 kB
69.154 kB
react-charts
LineChart
410.571 kB
124.202 kB
react-charts
ScatterChart
390.353 kB
118.433 kB
react-charts
Sparkline
91.253 kB
28.726 kB
react-charts
VerticalBarChart
425.412 kB
123.541 kB
react-charts
VerticalStackedBarChart
397.198 kB
119.445 kB
🤖 This report was generated against e539a6a8b68da35f25e570e70635bf25b87a2068

@github-actions

Copy link
Copy Markdown

Pull request demo site: URL

@Anush2303

Copy link
Copy Markdown
Contributor Author

@AtishayMsft

Copy link
Copy Markdown
Contributor

Could you rerun playwright report with sankey change

@Anush2303

Copy link
Copy Markdown
Contributor Author

Could you rerun playwright report with sankey change

okay will run. But we won't get any changes there because we have changed the link colors but in report only the node colors are visible.

@Anush2303

Copy link
Copy Markdown
Contributor Author

@Anush2303

Copy link
Copy Markdown
Contributor Author

Comment thread packages/charts/react-charts/library/src/components/SankeyChart/SankeyChart.tsx Outdated
@Anush2303
Anush2303 merged commit 00a98ea into microsoft:master Nov 14, 2025
12 checks passed
@Anush2303
Anush2303 deleted the usr/agupta/fixBlackSankey branch November 14, 2025 11:45
tudorpopams pushed a commit to tudorpopams/fluentui that referenced this pull request Apr 14, 2026
Co-authored-by: Anush <anushgupta@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants