Skip to content

fix(react-charts): Ensuring annotation keeps tied with chart always - #35486

Merged
srmukher merged 2 commits into
microsoft:masterfrom
srmukher:users/srmukher/ano_v9
Nov 14, 2025
Merged

fix(react-charts): Ensuring annotation keeps tied with chart always#35486
srmukher merged 2 commits into
microsoft:masterfrom
srmukher:users/srmukher/ano_v9

Conversation

@srmukher

@srmukher srmukher commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Work item: https://uifabric.visualstudio.com/iss/_workitems/edit/13601

Before:

image

After:

image

Making annotation position: relative part of the base wrapper style locks the annotation root to the chart’s bounds in every scenario. We keep overflow: auto gated behind the min-width reflow flag so scrolling only appears when that responsive mode needs it.

@srmukher
srmukher requested a review from a team as a code owner November 13, 2025 13:16
@github-actions

github-actions Bot commented Nov 13, 2025

Copy link
Copy Markdown

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-charts
AreaChart
401.251 kB
122.775 kB
401.301 kB
122.791 kB
50 B
16 B
react-charts
DeclarativeChart
718.172 kB
207.976 kB
718.222 kB
208.001 kB
50 B
25 B
react-charts
GanttChart
383.008 kB
115.934 kB
383.058 kB
115.953 kB
50 B
19 B
react-charts
GroupedVerticalBarChart
390.796 kB
118.48 kB
390.846 kB
118.496 kB
50 B
16 B
react-charts
HeatMapChart
385.088 kB
117.649 kB
385.138 kB
117.661 kB
50 B
12 B
react-charts
LineChart
410.521 kB
124.186 kB
410.571 kB
124.202 kB
50 B
16 B
react-charts
ScatterChart
390.303 kB
118.417 kB
390.353 kB
118.433 kB
50 B
16 B
react-charts
VerticalBarChart
425.362 kB
123.526 kB
425.412 kB
123.541 kB
50 B
15 B
react-charts
VerticalStackedBarChart
397.148 kB
119.428 kB
397.198 kB
119.445 kB
50 B
17 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-charts
DonutChart
297.311 kB
88.889 kB
react-charts
FunnelChart
288.594 kB
85.727 kB
react-charts
GaugeChart
312.216 kB
92.539 kB
react-charts
HorizontalBarChart
294.96 kB
86.77 kB
react-charts
HorizontalBarChartWithAxis
63 B
83 B
react-charts
Legends
234.066 kB
69.154 kB
react-charts
SankeyChart
199.508 kB
61.368 kB
react-charts
Sparkline
91.253 kB
28.726 kB
🤖 This report was generated against b49426b717fb2801d15f22c5d53b5ee5d585b58e

@github-actions

Copy link
Copy Markdown

Pull request demo site: URL

@srmukher srmukher changed the title Ensuring annotation keeps tied with chart always fix(react-charts): Ensuring annotation keeps tied with chart always Nov 13, 2025
@srmukher

Copy link
Copy Markdown
Contributor Author

@AtishayMsft

Copy link
Copy Markdown
Contributor

Playwright report: https://github.com/microsoft/fluentui-charting-contrib/actions/runs/19333309775

You ran the v8 playwright test. You need to run the v9 playwright test
https://github.com/microsoft/fluentui-charting-contrib/actions/runs/19352712275

@AtishayMsft AtishayMsft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@AtishayMsft AtishayMsft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@srmukher
srmukher merged commit e539a6a into microsoft:master Nov 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants