Skip to content

fix(react-charts): prevent histogram bar overlap - #36493

Open
4mthxmas20 wants to merge 1 commit into
microsoft:masterfrom
4mthxmas20:fix-vertical-bar-histogram-overlap
Open

fix(react-charts): prevent histogram bar overlap#36493
4mthxmas20 wants to merge 1 commit into
microsoft:masterfrom
4mthxmas20:fix-vertical-bar-histogram-overlap

Conversation

@4mthxmas20

Copy link
Copy Markdown

Summary

  • prevent numeric VerticalBarChart histograms from adding the extra half-bar domain margin used by non-histogram numeric bars
  • add regression coverage that verifies adjacent numeric histogram bars do not overlap
  • add a beachball patch change for @fluentui/react-charts

Fixes #36417

Testing

  • PASS: node_modules/.bin/jest --config jest.config.js src/components/VerticalBarChart/VerticalBarChart.test.tsx --runInBand
  • PASS: corepack yarn prettier --check packages/charts/react-charts/library/src/components/VerticalBarChart/VerticalBarChart.tsx packages/charts/react-charts/library/src/components/VerticalBarChart/VerticalBarChart.test.tsx change/@fluentui-react-charts-00f29ed5-2001-4731-a88c-cdaebc2a2858.json
  • PASS: commit hook ran prettier and node ./scripts/lint-staged/src/eslint on staged TS/TSX files

Notes: direct Nx targets (react-charts:test, react-charts:lint, react-charts:type-check) hung locally without output while building the project graph/plugin worker, so I used the package Jest command and targeted formatting/lint-staged verification.

@4mthxmas20
4mthxmas20 requested a review from a team as a code owner August 3, 2026 02:21
@4mthxmas20

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: VerticalBarChart histogram bars overlap with numeric bin centers

1 participant