test(react-color-picker): add hook state coverage - #36527
Open
Dmytro Kirpa (dmytrokirpa) wants to merge 1 commit into
Open
test(react-color-picker): add hook state coverage#36527Dmytro Kirpa (dmytrokirpa) wants to merge 1 commit into
Dmytro Kirpa (dmytrokirpa) wants to merge 1 commit into
Conversation
This was referenced Aug 6, 2026
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,46 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 413 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 882 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 159 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.chromium.png | 635 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
Victor Genaev (mainframev)
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Lock down the existing color-picker hook behavior before the reusable base-hook extraction in the next PR. Keeping this coverage in a separate bottom PR makes the behavioral expectations reviewable independently from the API refactor.
Changes
useAlphaSlider_unstableuseColorArea_unstableuseColorSlider_unstableuseColorPicker_unstableValidation
yarn nx test react-color-picker(13 suites, 132 tests, 4 snapshots)yarn nx lint react-color-pickerPR stack
Please review and merge the stack in this order.