Skip to content

Issue#4832: Break ContextualMenu Types hard dependency from class ContextualMenu #4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pchandoria wants to merge 3 commits into from
Closed

Issue#4832: Break ContextualMenu Types hard dependency from class ContextualMenu #4842

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2ce9d6
Breaking types dependency from ContextualMenu class
pchandoria May 10, 2018
8f12cf1
remove refernece from IContextualMenuSection as well
pchandoria May 10, 2018
fac2051
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
pchandoria May 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as React from 'react';
import { ContextualMenu } from './ContextualMenu';
import { DirectionalHint } from '../../common/DirectionalHint';
import { FocusZoneDirection, IFocusZoneProps } from '../../FocusZone';
import { IIconProps } from '../Icon/Icon.types';
Expand Down Expand Up @@ -29,7 +28,7 @@ export interface IContextualMenu {

}

export interface IContextualMenuProps extends React.Props<ContextualMenu>, IWithResponsiveModeState {
export interface IContextualMenuProps extends React.Props<any>, IWithResponsiveModeState {

@joschect joschect May 10, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely shouldn't be any. Make it an empty {} if it shouldn't correspond to anything.

Alternatively you could probably remove React.Props. It's really not supposed to extend that any more. It should certainly be removed in 6.0

@pchandoria pchandoria May 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the first attempt but it causes compile error. While true we should get rid of it, I am not sure what is story for being backward compatible

/**
* Optional callback to access the IContextualMenu interface. Use this instead of ref for accessing
* the public methods and properties of the component.
Expand Down Expand Up @@ -489,7 +488,7 @@ export interface IContextualMenuItem {
inactive?: boolean;
}

export interface IContextualMenuSection extends React.Props<ContextualMenu> {
export interface IContextualMenuSection extends React.Props<any> {

/**
* The items to include inside the section.
Expand Down