DetailsList: selection column header in single selection mode#7842
Merged
leddie24 merged 15 commits intoFeb 4, 2019
Conversation
natalieethell
requested review from
KevinTCoughlin,
betrue-final-final and
cschlechty
January 30, 2019 00:10
natalieethell
commented
Jan 30, 2019
| this._onRenderColumnHeaderTooltip | ||
| )} | ||
| </div>, | ||
| ariaLabelForSelectAllCheckbox && !this.props.onRenderColumnHeaderTooltip ? ( |
Contributor
Author
There was a problem hiding this comment.
All I did here was render ariaLabelForSelectionColumn in the label when isCheckboxHidden is true, since it becomes a header instead of a select all checkbox.
|
KevinTCoughlin
requested changes
Jan 31, 2019
KevinTCoughlin
left a comment
KevinTCoughlin
left a comment
Member
There was a problem hiding this comment.
🕐 will sync with @natalieethell re: approach.
KevinTCoughlin
approved these changes
Feb 1, 2019
…ailsHeader.base.tsx Co-Authored-By: natalieethell <naethell@microsoft.com>
…ailsHeader.base.tsx Co-Authored-By: natalieethell <naethell@microsoft.com>
…/natalieethell/office-ui-fabric-react into detailsListSelectionColumnHeader
Contributor
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
These changes render a basic, non-focusable column header for the checkboxes for the DetailsList in single selection mode. I spoke to Ben about the "non-focusable" aspect.
Additionally, the correct column header is now read out by the screen reader for each cell when navigating through the cells in scan mode. They were one off before. The before and after below are when navigating through the DetailsList "Advanced"/"Variable Row Heights" example.
Navigating to a thumbnail cell before:
non-selected, read-only, Column Header key
Navigating to a thumbnail cell after:
non-selected, read-only, Column Header thumbnail
Now you should also be able to navigate to the checkboxes' column header in scan mode.
@betrue-final-final could you look over the new snapshots? - Edit: Thanks!
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow