Refactored groupedList to its own component#8
Conversation
|
Hi @magellantoo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
@magellantoo, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
Hey, @dzearing - what do you think needs to be fixed/reconsidered? |
|
@ericthompson The PR was completed in VSO and copied over by David Zearing. The github PR is now redundant. |
|
Sorry, @ericthompson was on my phone and wanted to make sure this didn't go in redundantly. I should have just closed it (but i was also curious if pullapprove supported rejecting PRs that are already approved.) In the future if i see Approves and I also see blocking issues, I will mark Rejected as a way to halt commit train until issues are resolved. |
|
Makes sense - thanks for the explanations! On Jul 28, 2016, at 10:49 AM, David Zearing <notifications@github.commailto:notifications@github.com> wrote: Sorry, @ericthompsonhttps://github.com/ericthompson was on my phone and wanted to make sure this didn't go in redundantly. I should have just closed it (but i was also curious if pullapprove supported rejecting PRs that are already approved.) In the future if i see Approves and I also see blocking issues, I will mark Rejected as a way to halt commit train until issues are resolved. You are receiving this because you were mentioned. |
fixing setState logic
No description provided.