Skip to content

Refactored groupedList to its own component#8

Closed
lambertwang-zz wants to merge 1 commit into
microsoft:masterfrom
lambertwang-zz:groupedlist
Closed

Refactored groupedList to its own component#8
lambertwang-zz wants to merge 1 commit into
microsoft:masterfrom
lambertwang-zz:groupedlist

Conversation

@lambertwang-zz

Copy link
Copy Markdown

No description provided.

@msftclas

Copy link
Copy Markdown

Hi @magellantoo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas

Copy link
Copy Markdown

@magellantoo, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@wdo3650

wdo3650 commented Jul 25, 2016

Copy link
Copy Markdown
Contributor

Approved.

Approved with PullApprove

@gokunymbus

gokunymbus commented Jul 26, 2016

Copy link
Copy Markdown
Contributor

Approved

Approved with PullApprove

@dzearing

dzearing commented Jul 28, 2016

Copy link
Copy Markdown
Member

Rejected

Rejected with PullApprove

@ericthompson

Copy link
Copy Markdown
Contributor

Hey, @dzearing - what do you think needs to be fixed/reconsidered?

@lambertwang-zz

Copy link
Copy Markdown
Author

@ericthompson The PR was completed in VSO and copied over by David Zearing. The github PR is now redundant.

@dzearing

Copy link
Copy Markdown
Member

Sorry, @ericthompson was on my phone and wanted to make sure this didn't go in redundantly. I should have just closed it (but i was also curious if pullapprove supported rejecting PRs that are already approved.) In the future if i see Approves and I also see blocking issues, I will mark Rejected as a way to halt commit train until issues are resolved.

@ericthompson

Copy link
Copy Markdown
Contributor

Makes sense - thanks for the explanations!

On Jul 28, 2016, at 10:49 AM, David Zearing <notifications@github.commailto:notifications@github.com> wrote:

Sorry, @ericthompsonhttps://github.com/ericthompson was on my phone and wanted to make sure this didn't go in redundantly. I should have just closed it (but i was also curious if pullapprove supported rejecting PRs that are already approved.) In the future if i see Approves and I also see blocking issues, I will mark Rejected as a way to halt commit train until issues are resolved.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/8#issuecomment-235971788, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABWuNmV8Mgi0nJO9nlBkGpxQuasylceWks5qaOuvgaJpZM4JUeD6.

@lambertwang-zz
lambertwang-zz deleted the groupedlist branch October 13, 2017 21:19
@HamletDRC HamletDRC mentioned this pull request Jul 11, 2019
8 tasks
tharshada pushed a commit to tharshada/office-ui-fabric-react that referenced this pull request Jul 23, 2019
sopranopillow referenced this pull request in sopranopillow/fluentui Aug 1, 2019
@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants