ChoiceGroup fix#8053
Merged
Merged
Conversation
…c-react into choicegroup-fix
…both causing regressions.
…ui-fabric-react into choicegroup-fix # Conflicts: # common/changes/@uifabric/charting/subwayNav_2019-02-15-00-58.json # packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx
kenotron
approved these changes
Feb 20, 2019
kenotron
left a comment
kenotron
left a comment
Contributor
There was a problem hiding this comment.
I'm okay with the change since you're willing to take back some behavior in choicegroup
dzearing
requested review from
Jahnp,
atneik,
joschect and
micahgodbolt
as code owners
February 20, 2019 20:42
|
Contributor
|
🎉 Handy links: |
This was referenced Feb 20, 2019
This was referenced Feb 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
ChoiceGroup no longer has
data-is-focusableattributes. This is causing issues with ChoiceGroup used within a FocusZone.This will revert some fixes that address #5160, which we need to fix in FocusTrapZone.
This also reverts the usage of
tabindex="-1"in Popup. We've received numerous reports of regressions caused by this change. This was originally changed to allow for users to click within modals without focus elements to be able to dismiss them. I think this needs to be done within the content area, inside a trap zone, and not necessarily outside.But also if TrapZone were refactored, I think it could gracefully keep focus on the right element even if the outer container were focusable.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow