Skip to content

revert fix to find active element within iframe#8432

Merged
jspurlin merged 2 commits into
masterfrom
revert-active-element-in-iframe-fix
Mar 22, 2019
Merged

revert fix to find active element within iframe#8432
jspurlin merged 2 commits into
masterfrom
revert-active-element-in-iframe-fix

Conversation

@aftab-hassan

@aftab-hassan aftab-hassan commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

Pull request checklist

Description of changes

Revert changes caused by PR #8290 causing infinite loop upon showing a popup when an iframe is focused

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@size-auditor

size-auditor Bot commented Mar 22, 2019

Copy link
Copy Markdown
Bundle test Size (minified) Diff from master
CommandBar 180.051 kB BelowBaseline     -205 bytes
SpinButton 173.223 kB BelowBaseline     -205 bytes
DatePicker 199.099 kB BelowBaseline     -205 bytes
ContextualMenu 144.164 kB BelowBaseline     -205 bytes
SwatchColorPicker 176.22 kB BelowBaseline     -205 bytes
Breadcrumb 178.524 kB BelowBaseline     -205 bytes
Button 172.255 kB BelowBaseline     -205 bytes
Callout 85.673 kB BelowBaseline     -205 bytes
TeachingBubble 174.649 kB BelowBaseline     -205 bytes
Dialog 179.439 kB BelowBaseline     -205 bytes
ComboBox 217.588 kB BelowBaseline     -205 bytes
Persona 109.285 kB BelowBaseline     -205 bytes
DocumentCard 191.924 kB BelowBaseline     -205 bytes
Tooltip 85.444 kB BelowBaseline     -205 bytes
PersonaCoin 109.285 kB BelowBaseline     -205 bytes
Nav 169.627 kB BelowBaseline     -205 bytes
Modal 75.051 kB BelowBaseline     -205 bytes
MessageBar 169.894 kB BelowBaseline     -205 bytes
Pickers 253.016 kB BelowBaseline     -205 bytes
Pivot 168.169 kB BelowBaseline     -205 bytes
Popup 24.305 kB BelowBaseline     -205 bytes
KeytipLayer 98.857 kB BelowBaseline     -205 bytes
Dropdown 205.319 kB BelowBaseline     -205 bytes
Keytip 82.773 kB BelowBaseline     -205 bytes
HoverCard 94.757 kB BelowBaseline     -205 bytes
SearchBox 166.938 kB BelowBaseline     -205 bytes
Grid 163.291 kB BelowBaseline     -205 bytes
SelectedItemsList 204.292 kB BelowBaseline     -205 bytes
FloatingPicker 214.77 kB BelowBaseline     -205 bytes
Panel 177.983 kB BelowBaseline     -205 bytes
Facepile 188.399 kB BelowBaseline     -205 bytes

ExceedsTolerance  Exceeds Tolerance     ExceedsBaseline  Exceeds Baseline     BelowBaseline  Below Baseline     1 kB = 1000 bytes

@jspurlin
jspurlin merged commit 71d310d into master Mar 22, 2019
@msft-github-bot

Copy link
Copy Markdown
Contributor

🎉office-ui-fabric-react@v6.159.0 has been released which incorporates this pull request.:tada:

Handy links:

@KevinTCoughlin
KevinTCoughlin deleted the revert-active-element-in-iframe-fix branch March 22, 2019 03:25
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Showing a popup when an iframe is focused causes an infinite loop

5 participants