Refactor pull request handling to use default GitHub client instance#1884
Closed
Refactor pull request handling to use default GitHub client instance#1884
Conversation
…t client Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor -prr, -prc, -prs (pullRequestDescription, pullRequestReview, pullRequestComment) handling to use the default githubclient instance
Refactor pull request handling to use default GitHub client instance
Aug 19, 2025
Member
|
@copilot fix build |
…bClient.default() Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Author
Fixed! The build error was due to a missed Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
Investigator reportContext collection
AI Analysis
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the handling of pull request CLI options (
-prc,-prd,-prr) to use the default GitHub client instance instead of standalone functions, improving code consistency and maintainability.Problem
The CLI's pull request functionality was using standalone functions (
githubUpdatePullRequestDescription,githubCreateIssueComment,githubCreatePullRequestReviews,githubCreateIssue) directly instead of leveraging the existing default GitHub client instance pattern used elsewhere in the codebase.Solution
Added new methods to GitHubClient class:
createIssueCommentWithTag()- Enhanced version ofcreateIssueComment()with tag-based update/replace functionalityupdatePullRequestDescription()- Updates PR descriptions with tag-based content mergingcreatePullRequestReviews()- Creates PR review comments from code annotationsUpdated API layer:
packages/api/src/run.tsto useGitHubClient.default()instead of standalone functions for all GitHub operationstypes.tswith new method signaturesBenefits
Testing
-prc,-prd,-prr)GitHubClient.default()The refactoring follows the principle of minimal changes - only the necessary files were modified to achieve the consolidation goal while preserving all existing functionality.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.