Add msgo/module and msgo/ci telemetry counters

[gdams]

Summary

Add two new Microsoft-specific telemetry counters to incrementConfig() in telemetrystats.go, and vendor the updated go-infra/telemetry dependency (which includes the new DetectCI function).

fixes: https://github.com/microsoft/go-lab/issues/382

New counters

msgo/module:<module_path>

Reports the Go module path (from go.mod) of the project being built.

This counter is gated behind the MS_GO_INTERNAL_CUSTOMER environment variable and is only collected for first-party (1P) Microsoft customers who have explicitly opted in. It is not collected for general users of the Microsoft build of Go.

msgo/ci:<system>

Detects the CI system in use by inspecting environment variables via telemetry.DetectCI(os.Environ()). Reports values like azdo, github, gitlab, appveyor, etc. Only incremented when a CI system is detected.

Dependency changes

• Updated vendored github.com/microsoft/go-infra/telemetry to include the new ci.go file (DetectCI function) and updated config.json.

Patch changes

• Patch 0001 (Vendor external dependencies): Updated go-infra/telemetry dependency version, added ci.go to vendor.
• Patch 0009 (Add appinsights telemetry): Added the two new counters and their required imports.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds three Microsoft-specific telemetry counters (msgo/module, msgo/ci, msgo/systemcrypto) to the Microsoft build of Go, and vendors the updated go-infra/telemetry dependency providing the new DetectCI function.

Changes:

• Add three new counters in incrementConfig() with msgo/module gated behind MS_GO_INTERNAL_CUSTOMER env var.
• Vendor updated github.com/microsoft/go-infra/telemetry with new ci.go (DetectCI).
• Update config.json to register the new counter names.

Show a summary per file

File	Description
patches/0009-Add-appinsights-telemetry.patch	Adds the three new counters to telemetrystats.go with required imports.
patches/0001-Vendor-external-dependencies.patch	Vendors new ci.go, bumps dependency version, updates config.json.
go	Bumps the go submodule commit.

Copilot's findings

Comments suppressed due to low confidence (4)

patches/0001-Vendor-external-dependencies.patch:1

• Typo in counter name: mssgo/systemcrypto should be msgo/systemcrypto to match the actual counter incremented in telemetrystats.go. As-is, the counter emitted by the code will not match any registered name in config.json.
  patches/0001-Vendor-external-dependencies.patch:1
• The Jenkins detection (BUILD_ID + BUILD_URL) is checked before Google Cloud Build, but BUILD_ID is also set by Google Cloud Build. More importantly, the Google Cloud Build check is unreachable if Jenkins's BUILD_URL happens to be set, and conversely many GCB builds where PROJECT_ID is exported alongside an environment that has BUILD_URL could be misattributed. Consider checking GCB-unique variables (e.g. BUILDER_OUTPUT) and reordering / using more specific markers for each system to reduce false positives.
  patches/0001-Vendor-external-dependencies.patch:1
• The PR description mentions the counter as msgo/ci, but no entry for msgo/module:* review is needed since it requires module path values. Verify that msgo/module:* is acceptable in config.json schema (free-form wildcard counter) — if the upload schema requires enumerated values, * may not be honored.
  patches/0001-Vendor-external-dependencies.patch:1
• AWS_REGION is commonly set in many AWS environments (not just CodeBuild). CODEBUILD_BUILD_ID alone is sufficient and CodeBuild-specific; the extra AWS_REGION requirement risks false negatives where a CodeBuild runner doesn't export AWS_REGION. Consider dropping the AWS_REGION check.

• Files reviewed: 2/2 changed files
• Comments generated: 3

[dagood]

Discussion in https://github.com/microsoft/go-lab/issues/382