Skip to content

feat: add makeResetStyles to @griffel/react#235

Merged
layershifter merged 3 commits into
microsoft:mainfrom
layershifter:feat/add-react-make-reset-styles
Oct 4, 2022
Merged

feat: add makeResetStyles to @griffel/react#235
layershifter merged 3 commits into
microsoft:mainfrom
layershifter:feat/add-react-make-reset-styles

Conversation

@layershifter

@layershifter layershifter commented Oct 3, 2022

Copy link
Copy Markdown
Member

Requires #232.
Fixes #226.


This PR implements makeResetStyles() function in @griffel/react, see #225 for more context.

  • isInsideComponent is moved to a separate file
  • makeResetStyles is just a wrapper around makeResetStyles from @griffel/core
  • Adds bundle size fixtures for makeResetStyles in @griffel/core & @griffel/react

@github-actions

github-actions Bot commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
core
makeResetStyles (runtime)
0 B
0 B
16.192 kB
6.041 kB
🆕 New entry
react
makeResetStyles (runtime)
0 B
0 B
17.957 kB
6.777 kB
🆕 New entry
Unchanged fixtures
Package & Exports Size (minified/GZIP)
core
makeStyles + mergeClasses (build time)
1.834 kB
872 B
core
makeStyles + mergeClasses (runtime)
20.781 kB
7.72 kB
react
__css + mergeClasses (build time)
1.871 kB
869 B
react
__styles + mergeClasses (build time)
3.573 kB
1.609 kB
react
makeStaticStyles (runtime)
9.443 kB
4.068 kB
react
makeStyles + mergeClasses (runtime)
22.546 kB
8.432 kB
🤖 This report was generated against 740e37f4dacd4ac670b9ac8c48d0f5bed566376a

@layershifter
layershifter force-pushed the feat/add-react-make-reset-styles branch from c5cbc30 to e0038a8 Compare October 3, 2022 11:31
@layershifter
layershifter force-pushed the feat/add-react-make-reset-styles branch 2 times, most recently from 0b4459b to 9632f7b Compare October 4, 2022 10:54
@layershifter
layershifter marked this pull request as ready for review October 4, 2022 11:08
@layershifter
layershifter requested a review from a team as a code owner October 4, 2022 11:08
@layershifter
layershifter force-pushed the feat/add-react-make-reset-styles branch from 9632f7b to 4e9fb21 Compare October 4, 2022 14:42
Comment thread packages/react/src/utils/isInsideComponent.ts Outdated
Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
@layershifter
layershifter enabled auto-merge (squash) October 4, 2022 17:40
@layershifter
layershifter disabled auto-merge October 4, 2022 17:41
@layershifter
layershifter force-pushed the feat/add-react-make-reset-styles branch from fc034c0 to 346deb1 Compare October 4, 2022 17:44
@layershifter
layershifter enabled auto-merge (squash) October 4, 2022 17:46
@layershifter
layershifter merged commit f9a70d8 into microsoft:main Oct 4, 2022
@layershifter
layershifter deleted the feat/add-react-make-reset-styles branch October 4, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react: implement makeResetStyles

2 participants