feat: add makeResetStyles to @griffel/react#235
Merged
layershifter merged 3 commits intoOct 4, 2022
Conversation
Contributor
📊 Bundle size report
Unchanged fixtures
|
layershifter
force-pushed
the
feat/add-react-make-reset-styles
branch
from
October 3, 2022 11:31
c5cbc30 to
e0038a8
Compare
layershifter
force-pushed
the
feat/add-react-make-reset-styles
branch
2 times, most recently
from
October 4, 2022 10:54
0b4459b to
9632f7b
Compare
layershifter
marked this pull request as ready for review
October 4, 2022 11:08
layershifter
force-pushed
the
feat/add-react-make-reset-styles
branch
from
October 4, 2022 14:42
9632f7b to
4e9fb21
Compare
bsunderhus
reviewed
Oct 4, 2022
bsunderhus
approved these changes
Oct 4, 2022
Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
layershifter
enabled auto-merge (squash)
October 4, 2022 17:40
layershifter
disabled auto-merge
October 4, 2022 17:41
layershifter
force-pushed
the
feat/add-react-make-reset-styles
branch
from
October 4, 2022 17:44
fc034c0 to
346deb1
Compare
layershifter
enabled auto-merge (squash)
October 4, 2022 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #232.Fixes #226.
This PR implements
makeResetStyles()function in@griffel/react, see #225 for more context.isInsideComponentis moved to a separate filemakeResetStylesis just a wrapper aroundmakeResetStylesfrom@griffel/coremakeResetStylesin@griffel/core&@griffel/react