fix: use unique IDs to prevent instance collisions across bundles#126
Open
layershifter wants to merge 1 commit into
Open
fix: use unique IDs to prevent instance collisions across bundles#126layershifter wants to merge 1 commit into
layershifter wants to merge 1 commit into
Conversation
📊 Bundle size report
Unchanged fixtures
|
|
@layershifter could you provide insights on planned release date of this? |
Replace the module-scoped _lastId counter with crypto.getRandomValues() to generate unique IDs. This prevents ID collisions when multiple bundles include keyborg on the same page, where each bundle had its own _lastId starting at 0 and produced colliding keys in the shared window.__keyborg.refs map. Uses crypto.getRandomValues() (not crypto.randomUUID()) to support Edge 84+, Firefox 75+, Chrome 84+, Safari 14.1+. Closes microsoft#99 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
layershifter
force-pushed
the
fix/unique-instance-ids
branch
from
June 19, 2026 09:35
b261ee9 to
7b4cb62
Compare
Member
Author
mshoho
reviewed
Jun 19, 2026
| export function createKeyborg(win: Window): Keyborg { | ||
| const kwin = win as WindowWithKeyborg; | ||
| const id = "k" + ++_lastId; | ||
| const id = generateId(); |
Member
There was a problem hiding this comment.
If I am paranoid, I would use both incremented id + random number, not just one of them. random numbers can repeat (with unlikely, but non-zero probability). incremented part fully guarantees absence of the same instance collisions and strongly reduces slim chances of the multiple instance collision :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_lastIdcounter withcrypto.getRandomValues()to generate unique instance IDs_lastIdstarting at 0, causing ID collisions in the sharedwindow.__keyborg.refsmapcrypto.getRandomValues()(notcrypto.randomUUID()) to support Edge 84+, Firefox 75+, Chrome 84+, Safari 14.1+Closes #99
Supersedes #75 and #104
Test plan
npm run buildpassesnpm run lintpasses🤖 Generated with Claude Code