context menu items no longer have hover effects

[troy351]

monaco-editor version: 0.14.3
Browser: latest stable Chrome
OS: Win10
Steps or JS usage snippet reproducing the issue:

just see demo here https://microsoft.github.io/monaco-editor/
their background color should change when hovering

[spahnke]

Hi,

any news on this one? Although there is a PR associated this still doesn't work in 0.15.1. The background color does not change on hover and the active element has no background color either (e.g. in quickfixes).

Which CSS classes can I style in the meantime? I found action-menu-item for the hover but what about the active selected one?

Thanks!

[sbatten]

running from source does not reproduce this issue for me, but when I bundle a release, I can repro. Will take a look tomorrow with @rebornix

[alexdima]

@sbatten Thank you for investigating. The root cause is the use of <any> here

Once only the editor sources are analyzed, our tree shaker does not find any references to MenuActionItem.blur and proceeds to shake that code out. But that method is reachable from ActionBar.updateFocus. You can see this is a problem when finding all references: Find all references does not find the usage here. This is also a problem when e.g. deciding to rename the method from blur to blur2, i.e. no compilation errors will be given, but the code will no longer execute, as is the case in the packaged standalone editor.

[sbatten]

@alexandrudima ouch! thanks for that information, though. will keep this in mind

[spahnke]

Sorry for the spam, but it seems this broke again in 0.15.4