Merged
Conversation
Contributor
Author
|
This includes syntax highlighting for JSX. It may be useful to backport these to This also includes some more advanced markdown features currently not available in the |
remcohaszing
added a commit
to remcohaszing/emmet-monaco-es
that referenced
this pull request
May 13, 2022
The MDX support is based on microsoft/monaco-editor#3096, which hasn’t been merged yet.
hediet
reviewed
Jul 21, 2022
They represent JSX elements.
This is nice for writing content.
hediet
requested changes
Aug 3, 2022
Member
hediet
left a comment
There was a problem hiding this comment.
Thanks for your PR! I left a comment. Especially for third party contributions, tests are crucial!
5 tasks
2 tasks
2 tasks
JulianCataldo
added a commit
to JulianCataldo/astro-content
that referenced
this pull request
Sep 28, 2022
hediet
previously approved these changes
Mar 31, 2023
bpasero
previously approved these changes
Mar 31, 2023
The sample is taken from https://github.com/wooorm/markdown-tm-language.
Contributor
Author
|
Sorry it took so long, but I added some tests! |
|
Hello, is there any update? |
hediet
approved these changes
Jul 7, 2023
chrmarti
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial attempt to add MDX language support to Monaco editor. MDX is a language which extends markdown by allowing the use of JSX and ecmascript imports and exports.
I am having some issues implementing this though. Some help would be greatly appreciated.
I’ve been using the following code for testing:
The JSX component highlighting is broken due to the props. If they are removed, highlighting is fixed.FixedIs is possible to highlight the JavaScript expression inside the bold markdown text?Yep, doneIf I add the following JavaScript expressionNo longer throws, but the closing bracket does exit the{1 + {}}, an error is thrown:Error: mdx: cannot pop embedded language if not inside onejavascriptembedded language.I think it’s very much usable in the current state.