Skip to content

Fix playground samples type errors and add CI test#3722

Merged
hediet merged 2 commits intomicrosoft:mainfrom
tamayika:feature/website-playground-examples-type-check
Mar 7, 2023
Merged

Fix playground samples type errors and add CI test#3722
hediet merged 2 commits intomicrosoft:mainfrom
tamayika:feature/website-playground-examples-type-check

Conversation

@tamayika
Copy link
Copy Markdown
Contributor

@tamayika tamayika commented Mar 4, 2023

I found several playground samples have type errors.
So I added type checking test script and test CI to github actions.

Comment thread website/scripts/check-playground-samples-js.ts Outdated
Copy link
Copy Markdown
Member

@hediet hediet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot! Please see my comments.

Comment thread website/scripts/check-playground-samples-js.ts Outdated
Comment thread website/scripts/check-playground-samples-js.ts Outdated
Comment thread website/scripts/check-playground-samples-js.ts Outdated
@tamayika tamayika force-pushed the feature/website-playground-examples-type-check branch from 6abbb79 to 2b3444b Compare March 7, 2023 12:03
@tamayika
Copy link
Copy Markdown
Contributor Author

tamayika commented Mar 7, 2023

I made all in parallel.
But it saved only 10sec because Github Action's cpu spec is poor(2cpu).
In my environment(24cpu), it takes only 10sec to process all.

To pass all files to one tsc process failed due to const editor confliction.

@hediet
Copy link
Copy Markdown
Member

hediet commented Mar 7, 2023

Thanks! :)
Generally, please try to not force push to a PR that has been reviewed, as it resets what has been reviewed already. We have the policy to check every changed line we merge to main and a force push forces us to check all the files again.

@hediet hediet merged commit 80ee9b3 into microsoft:main Mar 7, 2023
@tamayika tamayika deleted the feature/website-playground-examples-type-check branch March 7, 2023 13:33
@hediet hediet added this to the March 2023 milestone Mar 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants