Fix playground samples type errors and add CI test#3722
Merged
hediet merged 2 commits intomicrosoft:mainfrom Mar 7, 2023
Merged
Fix playground samples type errors and add CI test#3722hediet merged 2 commits intomicrosoft:mainfrom
hediet merged 2 commits intomicrosoft:mainfrom
Conversation
tamayika
commented
Mar 4, 2023
hediet
requested changes
Mar 7, 2023
Member
hediet
left a comment
There was a problem hiding this comment.
Looks good, thanks a lot! Please see my comments.
6abbb79 to
2b3444b
Compare
Contributor
Author
|
I made all in parallel. To pass all files to one tsc process failed due to |
hediet
approved these changes
Mar 7, 2023
aeschli
approved these changes
Mar 7, 2023
Member
|
Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found several playground samples have type errors.
So I added type checking test script and test CI to github actions.