Call clearFiles on internal EmitOutput diagnostics, pass args down#4482
Merged
hediet merged 2 commits intomicrosoft:mainfrom May 30, 2024
Merged
Call clearFiles on internal EmitOutput diagnostics, pass args down#4482hediet merged 2 commits intomicrosoft:mainfrom
hediet merged 2 commits intomicrosoft:mainfrom
Conversation
jakebailey
changed the title
hediet
approved these changes
May 30, 2024
Member
|
Thanks! |
Member
Author
|
The next version of TS will have this be formally public, so some of the cruft will be able to go away when that upgrade happens (but this PR works for older versions too) |
jrieken
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emitting produces diagnostics. Unfortunately, these are marked as internal so were missed (microsoft/TypeScript#58317)
This change enables the playground to handle emit errors without crashing.
Also, pass args down so we can always get dts emit even on error.