Skip to content

ESM Progress#4950

Merged
hediet merged 7 commits intomainfrom
hediet/monaco-esm
Aug 28, 2025
Merged

ESM Progress#4950
hediet merged 7 commits intomainfrom
hediet/monaco-esm

Conversation

@hediet
Copy link
Copy Markdown
Member

@hediet hediet commented Jul 30, 2025

No description provided.

@hediet hediet force-pushed the hediet/monaco-esm branch from 16cbf6a to 8bfd864 Compare August 15, 2025 16:41
@hediet hediet force-pushed the hediet/monaco-esm branch from 8bfd864 to c38e22c Compare August 15, 2025 17:19
@hediet hediet marked this pull request as ready for review August 28, 2025 11:03
@hediet hediet enabled auto-merge (squash) August 28, 2025 11:04
@vs-code-engineering vs-code-engineering bot added this to the August 2025 milestone Aug 28, 2025
@hediet hediet merged commit e56ad4b into main Aug 28, 2025
4 checks passed
@hediet hediet deleted the hediet/monaco-esm branch August 28, 2025 11:35
Comment thread package.json
Comment on lines +80 to +81
"dependencies": {
"@types/trusted-types": "^1.0.6"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hediet was this intended to be added as a direct dependency?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! How did you notice?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By checking the package-lock.json diff after renovate opened a PR to update monaco-editor haha

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants