Conversation
| ob_createvpack_owneralias: quicdev | ||
| ob_createvpack_description: msquic.$(Build.SourceBranchName) | ||
| ob_createvpack_versionAs: string | ||
| ob_createvpack_version: 2.3.0-$(Build.BuildId) |
There was a problem hiding this comment.
Does our update version ps1 script still work for this, or does it need to be updated?
There was a problem hiding this comment.
that doesn't work for this. I have a plan to read the version number from a json file like you did in a separate PR.
There was a problem hiding this comment.
Actually, there is an issue. The BuildId in vpack version won't match MSQUIC_METADATA_ONEBRANCH_BUILD_ID.
There was a problem hiding this comment.
MSQUIC_METADATA_ONEBRANCH_BUILD_ID won't match the build ID of the pipeline that pushes vpack and creates the PR either because it's from the previous pipeline.
There was a problem hiding this comment.
Looks like we have been doing all the time. So, probably not a big deal.
There was a problem hiding this comment.
Does our update version ps1 script still work for this, or does it need to be updated?
nvm. I updated update-version.ps1.
Codecov Report
@@ Coverage Diff @@
## main #3763 +/- ##
==========================================
- Coverage 75.64% 75.54% -0.11%
==========================================
Files 56 56
Lines 15544 15544
==========================================
- Hits 11759 11743 -16
- Misses 3785 3801 +16 |
2 participants
Description
Move VPack to OneBranch pipeline.
Testing
Tested in OneBranch pipeline