Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3867 +/- ##
=======================================
Coverage ? 86.44%
=======================================
Files ? 56
Lines ? 16693
Branches ? 0
=======================================
Hits ? 14431
Misses ? 2262
Partials ? 0 |
jwhited
reviewed
Sep 23, 2023
jwhited
reviewed
Sep 23, 2023
Contributor
|
Interesting. Does Linux GSO not perform software fallback? |
mtfriesen
reviewed
Sep 25, 2023
mtfriesen
approved these changes
Sep 25, 2023
nibanks
added a commit
that referenced
this pull request
Sep 25, 2023
nibanks
added a commit
that referenced
this pull request
Sep 26, 2023
Contributor
In the case of software UDP GSO, Linux still requires the egress netdev to offload checksumming: https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/man7/udp.7?id=806eabd74910447f21005160e90957bde4db0183 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Linux epoll datapath to fallback to non-GSO sends if the
EIOerror is returned, which most likely indicates the NIC doesn't support it. This seems to be the case on at least some Android devices.Fixed #3865.
Testing
CI/CD for regression testing. Not sure how to actually test this fallback atm.
Documentation
N/A