Added support for custom OpenSSL selection#5799
Conversation
|
@microsoft-github-policy-service agree |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5799 +/- ##
==========================================
- Coverage 86.34% 85.68% -0.66%
==========================================
Files 60 60
Lines 18729 18732 +3
==========================================
- Hits 16172 16051 -121
- Misses 2557 2681 +124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guhetier
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I don't think we can use the find_package approach with QuicTLS.
Our longer term goal is to stop depending on QuicTLS completely (once OpenSSL 3.5 is broadly available), so we could also add these new build config work only for openssl, not quictls.
f64c75a to
12ead5d
Compare
|
@toxicteddy00077 Hi, I found a missing entry for Win32 in submodules/CMakeLists.txt. |
12ead5d to
bd50c40
Compare
bd50c40 to
42a06d4
Compare
guhetier
left a comment
There was a problem hiding this comment.
Sorry for the delay. One last thing I caught on the last check.
We should probably update our requirements, but in the meantime, and especially since this targets Linux, we should be compatible.
42a06d4 to
6da2ca2
Compare
Closes #5614
Added support for choosing custom OpenSSL version with three prospective methods:
I mostly built on the suggestion given by the issue author