Skip to content

Added support for custom OpenSSL selection#5799

Merged
guhetier merged 1 commit intomicrosoft:mainfrom
toxicteddy00077:add-openssl-version-support
Mar 4, 2026
Merged

Added support for custom OpenSSL selection#5799
guhetier merged 1 commit intomicrosoft:mainfrom
toxicteddy00077:add-openssl-version-support

Conversation

@toxicteddy00077
Copy link
Contributor

Closes #5614

Added support for choosing custom OpenSSL version with three prospective methods:

  1. Use submodule
  2. Use OPENSSL_LIB_DIR and OPENSSL_INCLUDE_DIR variables
  3. Use find_package

I mostly built on the suggestion given by the issue author

@toxicteddy00077 toxicteddy00077 requested a review from a team as a code owner February 18, 2026 18:29
@toxicteddy00077
Copy link
Contributor Author

@microsoft-github-policy-service agree

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.68%. Comparing base (3f1d8ec) to head (6da2ca2).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5799      +/-   ##
==========================================
- Coverage   86.34%   85.68%   -0.66%     
==========================================
  Files          60       60              
  Lines       18729    18732       +3     
==========================================
- Hits        16172    16051     -121     
- Misses       2557     2681     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@guhetier guhetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I don't think we can use the find_package approach with QuicTLS.

Our longer term goal is to stop depending on QuicTLS completely (once OpenSSL 3.5 is broadly available), so we could also add these new build config work only for openssl, not quictls.

@toxicteddy00077 toxicteddy00077 force-pushed the add-openssl-version-support branch from f64c75a to 12ead5d Compare February 19, 2026 10:01
@guhetier guhetier enabled auto-merge (squash) February 19, 2026 18:48
@guhetier guhetier disabled auto-merge February 19, 2026 18:48
@masa-koz
Copy link
Contributor

@toxicteddy00077 Hi, I found a missing entry for Win32 in submodules/CMakeLists.txt.

--- a/submodules/CMakeLists.txt
+++ b/submodules/CMakeLists.txt
@@ -165,6 +165,7 @@ if (WIN32)
     )

     add_library(OpenSSLQuic::OpenSSLQuic ALIAS OpenSSLQuic)
+    add_library(OpenSSL::MsQuic ALIAS OpenSSLQuic)

@toxicteddy00077 toxicteddy00077 force-pushed the add-openssl-version-support branch from 12ead5d to bd50c40 Compare February 24, 2026 09:30
@toxicteddy00077
Copy link
Contributor Author

toxicteddy00077 commented Feb 24, 2026

Thanks @masa-koz good catch, @guhetier please check now

@toxicteddy00077 toxicteddy00077 force-pushed the add-openssl-version-support branch from bd50c40 to 42a06d4 Compare March 1, 2026 05:53
Copy link
Collaborator

@guhetier guhetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. One last thing I caught on the last check.
We should probably update our requirements, but in the meantime, and especially since this targets Linux, we should be compatible.

@toxicteddy00077 toxicteddy00077 force-pushed the add-openssl-version-support branch from 42a06d4 to 6da2ca2 Compare March 4, 2026 16:43
@toxicteddy00077 toxicteddy00077 requested a review from guhetier March 4, 2026 16:44
@guhetier guhetier merged commit ac1b4d5 into microsoft:main Mar 4, 2026
523 checks passed
guhetier added a commit that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to use custom OpenSSL version

3 participants