forwarder: handle OOM/null paths in stream and connection callbacks#5826
Closed
YuF-9468 wants to merge 1 commit intomicrosoft:mainfrom
Closed
forwarder: handle OOM/null paths in stream and connection callbacks#5826YuF-9468 wants to merge 1 commit intomicrosoft:mainfrom
YuF-9468 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
guhetier
requested changes
Mar 2, 2026
| } | ||
| CXPLAT_FRE_ASSERT(QUIC_SUCCEEDED(Status)); | ||
| if (QUIC_FAILED(Status)) { | ||
| ForwardedSend::Delete(SendContext); |
Collaborator
There was a problem hiding this comment.
There is no point to handle cleanup if we assert success. FRE asserts are always active and fail-fast, resources will be returned to the OS anyway.
| auto LocalStream = new(std::nothrow) MsQuicStream(Event->PEER_STREAM_STARTED.Stream, CleanUpAutoDelete, StreamCallback, PeerStream); | ||
| if (!LocalStream) { | ||
| delete PeerStream; | ||
| MsQuic->StreamClose(Event->PEER_STREAM_STARTED.Stream); |
Collaborator
There was a problem hiding this comment.
Redundant with #5807 and has the same double-free issue as the first iteration of this PR.
Author
|
Thanks for the review — agreed. This PR overlaps with #5807, so I'll close this one and keep the effort focused there to avoid duplicate review load. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ForwardedSendallocations inStreamCallbackSendContextbefore asserting on unexpectedStreamSendfailures to avoid leak-on-assert pathMsQuicStreamandMsQuicConnectionallocations in forwarder callbacksFixes #5806
Testing
src/tools/forwarder/forwarder.cpp.