Fix survey news showing multiple times and when users opt out#1095
Merged
mousetraps merged 4 commits intomicrosoft:masterfrom Jun 23, 2016
Merged
Fix survey news showing multiple times and when users opt out#1095mousetraps merged 4 commits intomicrosoft:masterfrom
mousetraps merged 4 commits intomicrosoft:masterfrom
Conversation
Bug Not honoring never setting for Survey news options Fix Make sure we do honor this option and never automatically display survey news when enabled. Testing Manual testing by clearing out cache and hitting this same code path multiple times.
mjbvz
changed the title
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1086
Bug
Not honoring never setting for Survey news options. The never case is actually the worst one since it can open multiple survey news pages, one for each project.
Fix
Make sure we do honor this option and never automatically display survey news when enabled.
Testing
Manually verified bad behavior before and that this change fixes the bad behavior.
Closes #1086