Extract functions in Diagnostics command#1118
Merged
mjbvz merged 4 commits intomicrosoft:masterfrom Jul 5, 2016
Merged
Conversation
We're looking to add some additional project info to our Diagnostics / Telemetry (microsoft#1116). I've took a quick pass through the current diagnostics window to clean up the code a bit and hopefully make this easier. The cleanup extracted functionality for logging each of the major info groups, such as project or assemblies. This just organizes and cleans up the code so that adding new fields should be easier.
| // about the exception. We'll add it to the output, | ||
| // rather than crashing. | ||
| res.AppendLine("Project: " + ex.Message); | ||
| res.AppendLine(Indent(8, "Kind: Node.js")); |
Contributor
There was a problem hiding this comment.
Should also be de-dented if project is de-dented
Contributor
|
minor comments and 👍 after that! |
Contributor
Author
|
Following up with #1119 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're looking to add some additional project info to our Diagnostics / Telemetry (#1116). I've took a quick pass through the current diagnostics window to clean up the code a bit and hopefully make this easier.
The cleanup extracted functionality for logging each of the major info groups, such as project or assemblies. This just organizes and cleans up the code so that adding new fields should be easier.