Skip to content

Fix Typings output Encoding #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjbvz merged 1 commit into from
Jul 7, 2016
Merged

Fix Typings output Encoding #1124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Nodejs/Product/Nodejs/TypingsAcquisition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
using System.Linq;
using System.IO;
using System.Security;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.VisualStudioTools.Project;
Expand Down Expand Up @@ -112,7 +113,9 @@ private async Task<bool> ExecuteTypingsTool(IEnumerable<string> arguments, Redir
null,
false,
redirector,
quoteArgs: true)) {
quoteArgs: true,
outputEncoding: Encoding.UTF8,
errorEncoding: Encoding.UTF8)) {
if (!process.IsStarted) {
// Process failed to start, and any exception message has
// already been sent through the redirector
Expand Down