Skip to content

Log Top Level Npm Packages in Diagnostics Window#1133

Merged
mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz:diagnostic-log-npm-packages
Jul 11, 2016
Merged

Log Top Level Npm Packages in Diagnostics Window#1133
mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz:diagnostic-log-npm-packages

Conversation

@mjbvz
Copy link
Copy Markdown
Contributor

@mjbvz mjbvz commented Jul 8, 2016

Issue #1116

Bug

To investigate perf issues with Typescript/Salsa, we would like to be able to request a list of installed node modules when a user reports a performance issue.

Fix

Adds installed node module information to the Diagnostic window. If a user is running into perf issues, we can request that they provide the output of the Diagnostics window to us in order to help with out investigations.

Testing

Tested with a few different project/solution types

Here's an example for a solution with two express projects:

Use Ctrl-C to copy contents

Projects:
    Project: ExpressApp17\ExpressApp17.njsproj
        Kind: Node.js
        StartupFile: C:\Users\matb.REDMOND\documents\visual studio 2015\Projects\ExpressApp17\ExpressApp17\bin\www
        WorkingDirectory: .
        PublishUrl: <undefined>
        SearchPath: <undefined>
        CommandLineArguments: <undefined>
        Analysis Log:
        Analysis loading...
        Top Level Node Packages (9):
            body-parser 1.8.4
            cookie-parser 1.3.5
            debug 2.0.0
            express 4.9.8
            jade 1.6.0
            mocha 2.5.3
            morgan 1.3.2
            serve-favicon 2.1.7
            stylus 0.42.3

        Project Info:
            .js (included in project):
                Number of Files: 4
                Average Line Count: 22
                Max Line Count: 61
            .d.ts (included in project):
                Number of Files: 14
                Average Line Count: 418
                Max Line Count: 2557
            .js (excluded from project):
                Number of Files: 641
                Average Line Count: 194
                Max Line Count: 15226
            .html (excluded from project):
                Number of Files: 6
                Average Line Count: 106
                Max Line Count: 324

    Project: ExpressApp1\ExpressApp1.njsproj
        Kind: Node.js
        StartupFile: C:\Users\matb.REDMOND\documents\visual studio 2015\Projects\ExpressApp17\ExpressApp1\bin\www
        WorkingDirectory: .
        PublishUrl: <undefined>
        SearchPath: <undefined>
        CommandLineArguments: <undefined>
        Analysis Log:
        Analysis loading...
        Top Level Node Packages (8):
            body-parser 1.8.4
            cookie-parser 1.3.5
            debug 2.0.0
            express 4.9.8
            jade 1.6.0
            morgan 1.3.2
            serve-favicon 2.1.7
            stylus 0.42.3

        Project Info:
            .js (included in project):
                Number of Files: 3
                Average Line Count: 26
                Max Line Count: 61
            .d.ts (included in project):
                Number of Files: 13
                Average Line Count: 432
                Max Line Count: 2557
            .js (excluded from project):
                Number of Files: 430
                Average Line Count: 179
                Max Line Count: 15226
            .html (excluded from project):
                Number of Files: 3
                Average Line Count: 88
                Max Line Count: 188

closes #1116

Bug
To investigate perf issues with Typescript/Salsa, we would like to be able to collect a list of installed node modules from users.

Fix
Adds this information to the Diagnostic window. If a user is running into perf issues, we can requires that they provide the output of the Diagnostics window to us in order to help with out investigations

Testing
Tested with a few different project/solution types

Here's an example for a solution with two express projects:

```
Use Ctrl-C to copy contents

Projects:
    Project: ExpressApp17\ExpressApp17.njsproj
        Kind: Node.js
        StartupFile: C:\Users\matb.REDMOND\documents\visual studio 2015\Projects\ExpressApp17\ExpressApp17\bin\www
        WorkingDirectory: .
        PublishUrl: <undefined>
        SearchPath: <undefined>
        CommandLineArguments: <undefined>
        Analysis Log:
        Analysis loading...
        Top Level Node Packages (9):
            body-parser 1.8.4
            cookie-parser 1.3.5
            debug 2.0.0
            express 4.9.8
            jade 1.6.0
            mocha 2.5.3
            morgan 1.3.2
            serve-favicon 2.1.7
            stylus 0.42.3

        Project Info:
            .js (included in project):
                Number of Files: 4
                Average Line Count: 22
                Max Line Count: 61
            .d.ts (included in project):
                Number of Files: 14
                Average Line Count: 418
                Max Line Count: 2557
            .js (excluded from project):
                Number of Files: 641
                Average Line Count: 194
                Max Line Count: 15226
            .html (excluded from project):
                Number of Files: 6
                Average Line Count: 106
                Max Line Count: 324

    Project: ExpressApp1\ExpressApp1.njsproj
        Kind: Node.js
        StartupFile: C:\Users\matb.REDMOND\documents\visual studio 2015\Projects\ExpressApp17\ExpressApp1\bin\www
        WorkingDirectory: .
        PublishUrl: <undefined>
        SearchPath: <undefined>
        CommandLineArguments: <undefined>
        Analysis Log:
        Analysis loading...
        Top Level Node Packages (8):
            body-parser 1.8.4
            cookie-parser 1.3.5
            debug 2.0.0
            express 4.9.8
            jade 1.6.0
            morgan 1.3.2
            serve-favicon 2.1.7
            stylus 0.42.3

        Project Info:
            .js (included in project):
                Number of Files: 3
                Average Line Count: 26
                Max Line Count: 61
            .d.ts (included in project):
                Number of Files: 13
                Average Line Count: 432
                Max Line Count: 2557
            .js (excluded from project):
                Number of Files: 430
                Average Line Count: 179
                Max Line Count: 15226
            .html (excluded from project):
                Number of Files: 3
                Average Line Count: 88
                Max Line Count: 188

```
@mousetraps
Copy link
Copy Markdown
Contributor

👍

@mjbvz mjbvz merged commit bfb1a5b into microsoft:master Jul 11, 2016
@mjbvz mjbvz removed the in-progress label Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add better diagnostic info for ES6 Mode IntelliSense

3 participants