Log Top Level Npm Packages in Diagnostics Window#1133
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Jul 11, 2016
Merged
Conversation
Bug
To investigate perf issues with Typescript/Salsa, we would like to be able to collect a list of installed node modules from users.
Fix
Adds this information to the Diagnostic window. If a user is running into perf issues, we can requires that they provide the output of the Diagnostics window to us in order to help with out investigations
Testing
Tested with a few different project/solution types
Here's an example for a solution with two express projects:
```
Use Ctrl-C to copy contents
Projects:
Project: ExpressApp17\ExpressApp17.njsproj
Kind: Node.js
StartupFile: C:\Users\matb.REDMOND\documents\visual studio 2015\Projects\ExpressApp17\ExpressApp17\bin\www
WorkingDirectory: .
PublishUrl: <undefined>
SearchPath: <undefined>
CommandLineArguments: <undefined>
Analysis Log:
Analysis loading...
Top Level Node Packages (9):
body-parser 1.8.4
cookie-parser 1.3.5
debug 2.0.0
express 4.9.8
jade 1.6.0
mocha 2.5.3
morgan 1.3.2
serve-favicon 2.1.7
stylus 0.42.3
Project Info:
.js (included in project):
Number of Files: 4
Average Line Count: 22
Max Line Count: 61
.d.ts (included in project):
Number of Files: 14
Average Line Count: 418
Max Line Count: 2557
.js (excluded from project):
Number of Files: 641
Average Line Count: 194
Max Line Count: 15226
.html (excluded from project):
Number of Files: 6
Average Line Count: 106
Max Line Count: 324
Project: ExpressApp1\ExpressApp1.njsproj
Kind: Node.js
StartupFile: C:\Users\matb.REDMOND\documents\visual studio 2015\Projects\ExpressApp17\ExpressApp1\bin\www
WorkingDirectory: .
PublishUrl: <undefined>
SearchPath: <undefined>
CommandLineArguments: <undefined>
Analysis Log:
Analysis loading...
Top Level Node Packages (8):
body-parser 1.8.4
cookie-parser 1.3.5
debug 2.0.0
express 4.9.8
jade 1.6.0
morgan 1.3.2
serve-favicon 2.1.7
stylus 0.42.3
Project Info:
.js (included in project):
Number of Files: 3
Average Line Count: 26
Max Line Count: 61
.d.ts (included in project):
Number of Files: 13
Average Line Count: 432
Max Line Count: 2557
.js (excluded from project):
Number of Files: 430
Average Line Count: 179
Max Line Count: 15226
.html (excluded from project):
Number of Files: 3
Average Line Count: 88
Max Line Count: 188
```
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1116
Bug
To investigate perf issues with Typescript/Salsa, we would like to be able to request a list of installed node modules when a user reports a performance issue.
Fix
Adds installed node module information to the Diagnostic window. If a user is running into perf issues, we can request that they provide the output of the Diagnostics window to us in order to help with out investigations.
Testing
Tested with a few different project/solution types
Here's an example for a solution with two express projects:
closes #1116