-
Notifications
You must be signed in to change notification settings - Fork 354
Lightweight installer work #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b622ccb
8cce55d
6d44125
b3f4f79
6b22330
2bf3abb
7f73eba
643b284
f1a750e
db9e7f6
9527f54
310f127
7cc3735
e2977be
931da7e
972da19
c60556c
cc8a10b
ca16fde
a06fee0
bedfe9c
4e99792
47be8e2
8e8cdec
d5f8b2a
f304c3b
0a888f1
d7c9d88
80415de
d385a8f
91ba45e
fc56ff2
a976dab
a36cf66
645f82d
2971ece
0e85d41
daad4d6
120477c
8a727a9
22412fb
86086bc
ebfb1d0
c4cbaaa
b4b3e2c
2c66f2a
87de392
77031d1
cf74bc9
857fdd3
a7ca953
951b84f
830cf29
2056487
e74e046
3933f2a
1d8a0a5
e4b52a9
8f3776b
52a1e5b
7f183e7
8bc2091
92331d2
456b9d5
25e9047
4b9adba
27748fd
de9b6a2
7644815
80a53db
42a68b1
5689dd9
d053790
9708bd7
6b54088
fefd303
7e49c85
606727c
ad3ede4
aef22f3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,27 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Vsix xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" Version="1.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2010"> | ||
| <Identifier Id="29102E6C-34F2-4FF1-BA2F-C02ADE3846E8"> | ||
| <Name>Node.js Tools - Interactive Window</Name> | ||
| <Author>Microsoft</Author> | ||
| <Version>1.2</Version> | ||
| <Description xml:space="preserve">Node.js Tools - Interactive Window</Description> | ||
| <MoreInfoUrl>http://go.microsoft.com/fwlink/?LinkId=785971</MoreInfoUrl> | ||
| <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011"> | ||
| <Metadata> | ||
| <Identity Id="29102E6C-34F2-4FF1-BA2F-C02ADE3846E8" Version="1.2" Language="en-US" Publisher="Microsoft" /> | ||
| <DisplayName>Node.js Tools - Interactive Window</DisplayName> | ||
| <Description xml:space="preserve">Node.js Tools - Interactive Window.</Description> | ||
| <MoreInfo>http://go.microsoft.com/fwlink/?LinkId=785971</MoreInfo> | ||
| <GettingStartedGuide>http://go.microsoft.com/fwlink/?LinkId=785972</GettingStartedGuide> | ||
| <Locale>1033</Locale> | ||
| <InstalledByMsi>true</InstalledByMsi> | ||
| <Icon>NodeJS.ico</Icon> | ||
| <PreviewImage>NodeJS_200x.png</PreviewImage> | ||
| <SystemComponent>false</SystemComponent> | ||
| <SupportedProducts> | ||
| <VisualStudio Version="11.0"> | ||
| <Edition>Pro</Edition> | ||
| <Edition>VWDExpress</Edition> | ||
| </VisualStudio> | ||
| </SupportedProducts> | ||
| <SupportedFrameworkRuntimeEdition MinVersion="4.0" /> | ||
| </Identifier> | ||
| <References> | ||
| <Reference Id="Microsoft.VisualStudio.MPF" MinVersion="10.0"> | ||
| <Name>Visual Studio MPF</Name> | ||
| </Reference> | ||
| </References> | ||
| <Content> | ||
| <VsPackage>|%CurrentProject%;PkgdefProjectOutputGroup|</VsPackage> | ||
| <MefComponent>|%CurrentProject%|</MefComponent> | ||
| <Assembly AssemblyName="|%CurrentProject%;_GetAssemblyName|">|%CurrentProject%|</Assembly> | ||
| </Content> | ||
|
|
||
| </Vsix> | ||
| </Metadata> | ||
| <!-- Version="11.0" specifies the minimum (not the maximum) version, and the | ||
| Id specifications are minimums; any SKU equal or 'higher' will accept | ||
| them. --> | ||
| <Installation> | ||
| <InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.Community" /> | ||
| <InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.Pro" /> | ||
| <InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.Enterprise" /> | ||
| <InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.VSWinExpress" /> | ||
| <InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.VWDExpress" /> | ||
| <InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.VSWinDesktopExpress" /> | ||
| </Installation> | ||
| <Assets> | ||
| <Asset Type="Microsoft.VisualStudio.Package" Path="|%CurrentProject%|" d:Source="Project" d:ProjectName="%CurrentProject%" /> | ||
| <Asset Type="Microsoft.VisualStudio.Assembly" Path="|%CurrentProject%|" /> | ||
| <Asset Type="Microsoft.VisualStudio.MefComponent" Path="|%CurrentProject%|" /> | ||
| </Assets> | ||
| </PackageManifest> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,7 @@ | |
| <Target Name="CopyFilesToOutputDirectory"/> | ||
|
|
||
| <Target Name="CoreCompile"> | ||
| <Error Condition="!Exists('$(VSToolsPath)\TypeScript\Microsoft.TypeScript.targets') And '$(EnableTypeScript)' == 'true'" Text="TypeScript is not installed but TypeScript support is enabled in this project. Please download and install TypeScript http://go.microsoft.com/fwlink/?LinkID=393159&clcid=0x409."></Error> | ||
| <Error Condition="!Exists('$(VSToolsPath)\TypeScript\Microsoft.TypeScript.targets') And '$(EnableTypeScript)' == 'true' And '$(VisualStudioVersion)' != '15.0'" Text="TypeScript is not installed but TypeScript support is enabled in this project. Please download and install TypeScript http://go.microsoft.com/fwlink/?LinkID=393159&clcid=0x409."></Error> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ahh, I see. "Import Project" includes the fallback msbuild behavior, but not errors/messages because they are less constrained in their use case. Given that restriction, this appears to be the correct fix, though we should probably add a comment to clarify. |
||
| <PropertyGroup> | ||
| <_NodeModulesContentProperty>@(NodeModulesContent)</_NodeModulesContentProperty> | ||
| </PropertyGroup> | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean this up