Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
b622ccb
generate vsix during build
mousetraps Jul 2, 2016
8cce55d
create Nodejs swixproj and swr files
mousetraps Jul 2, 2016
6d44125
add .vsmanproj
mousetraps Jul 2, 2016
b3f4f79
ADd .swixproj and .swr files for Profiling and InteractiveWindow
mousetraps Jul 2, 2016
6b22330
build and merge all three manifests
mousetraps Jul 2, 2016
2bf3abb
reorder .vsmanproj so that FinalizeManifest appears before MicroBuild…
mousetraps Jul 2, 2016
7f73eba
fix swixproj & vsmanproj build issues
mousetraps Jul 3, 2016
643b284
add sideload vsmanproj
mousetraps Jul 3, 2016
f1a750e
generate vsixs
mousetraps Jul 3, 2016
db9e7f6
update vsix certificate
mousetraps Jul 11, 2016
9527f54
add script to download microbuild packages
mousetraps Jul 11, 2016
310f127
build setup project and properly sign vsix's
mousetraps Jul 11, 2016
7cc3735
Add PackagesPath environment variable
mousetraps Jul 11, 2016
e2977be
copy swix outputs to staging directory
mousetraps Jul 11, 2016
931da7e
mkdir vsdrop
mousetraps Jul 11, 2016
972da19
update setup script for microbuild
mousetraps Jul 11, 2016
c60556c
fix profiling vsix path
mousetraps Jul 11, 2016
cc8a10b
fix build script
mousetraps Jul 11, 2016
ca16fde
Gate swix include to vs15 builds
mjbvz Jul 11, 2016
a06fee0
Update to github link
mjbvz Jul 11, 2016
bedfe9c
Added empty lighweight install targets
mjbvz Jul 12, 2016
4e99792
Remove commented out sections of swixproj files
mjbvz Jul 12, 2016
47be8e2
Try updatingswr path
mjbvz Jul 12, 2016
8e8cdec
Correct path
mjbvz Jul 12, 2016
d5f8b2a
Revert payload path change
mjbvz Jul 12, 2016
f304c3b
Bump SwixBuild version
mjbvz Jul 12, 2016
0a888f1
Fix product name NodeJs -> NodeJsTools
mjbvz Jul 13, 2016
d7c9d88
Fix targets vsix path
mjbvz Jul 13, 2016
80415de
Fix targets vsix name in swixproj
mjbvz Jul 13, 2016
d385a8f
Reorder targets swixproj
mjbvz Jul 13, 2016
91ba45e
Rename targets file
mjbvz Jul 13, 2016
fc56ff2
Revert targets changes
mjbvz Jul 13, 2016
a976dab
Change target mapping name
mjbvz Jul 13, 2016
a36cf66
Rename swr targets
mjbvz Jul 13, 2016
645f82d
Update targets to point to VisualStudio.targs
mjbvz Jul 13, 2016
2971ece
reorder property groups
mjbvz Jul 13, 2016
0e85d41
Rename targets file source
mjbvz Jul 14, 2016
daad4d6
Revert assembly version
mjbvz Jul 14, 2016
120477c
Merge branch 'master' into lightweight-install
mjbvz Jul 18, 2016
8a727a9
Use msbuild for vs version
mjbvz Jul 18, 2016
22412fb
Merge branch 'master' into lightweight-install
mjbvz Jul 18, 2016
86086bc
Remove package registration logic
mjbvz Jul 19, 2016
ebfb1d0
Remove pkgdef file
mjbvz Jul 19, 2016
c4cbaaa
Exclude pkgdef from vsix
mjbvz Jul 19, 2016
b4b3e2c
Merge branch 'master' into lightweight-install
mjbvz Jul 20, 2016
2c66f2a
Remove non-willow dep link
mjbvz Jul 20, 2016
87de392
Merge branch 'master' into lightweight-install
mjbvz Jul 20, 2016
77031d1
Try removing templates from vsix manifest
mjbvz Jul 20, 2016
cf74bc9
Remove testWwindow dep
mjbvz Jul 20, 2016
857fdd3
Revert removing project template manifests from vsixmanifest
mjbvz Jul 21, 2016
a7ca953
Merge branch 'master' into lightweight-install
mjbvz Jul 21, 2016
951b84f
Fix duplicate template installs for willow
mjbvz Jul 21, 2016
830cf29
Fix duplicate dir name
mjbvz Jul 21, 2016
2056487
Fix duplicate typescript project template ids
mjbvz Jul 21, 2016
e74e046
Revert project template changes
mjbvz Jul 21, 2016
3933f2a
Remove vstman files
mjbvz Jul 22, 2016
1d8a0a5
Revert vsman change since it breaks regular cases
mjbvz Jul 22, 2016
e4b52a9
Disable typescript error on vs15
mjbvz Jul 27, 2016
8f3776b
Added ProvideCodeBase to assembly info
mjbvz Jul 28, 2016
52a1e5b
Revert provide project item
mjbvz Jul 28, 2016
7f183e7
Add other codebases to pkgdef
mjbvz Jul 28, 2016
8bc2091
Add reference to dev15 telemetry
mjbvz Jul 29, 2016
92331d2
Update telemetry version
mjbvz Jul 29, 2016
456b9d5
Copy webroledll
mjbvz Jul 29, 2016
25e9047
Updating item templates to not be zipped
mjbvz Jul 29, 2016
4b9adba
Fix xml
mjbvz Jul 29, 2016
27748fd
Use correct path for item templates
mjbvz Jul 29, 2016
de9b6a2
Move file templates up a level
mjbvz Jul 29, 2016
7644815
Update filetemplates path
mjbvz Jul 29, 2016
80a53db
address most CR comments
mousetraps Aug 2, 2016
42a68b1
fix sideload script
mousetraps Aug 2, 2016
5689dd9
Revert "Update filetemplates path"
mousetraps Aug 2, 2016
d053790
Revert "Move file templates up a level"
mousetraps Aug 2, 2016
9708bd7
Revert "Use correct path for item templates"
mousetraps Aug 2, 2016
6b54088
Revert "Fix xml"
mousetraps Aug 2, 2016
fefd303
Revert "Updating item templates to not be zipped"
mousetraps Aug 2, 2016
7e49c85
remove .vstman files
mousetraps Aug 2, 2016
606727c
remove .vstman files from *.csproj
mousetraps Aug 2, 2016
ad3ede4
Remove unused IScopeNode file
mjbvz Aug 4, 2016
aef22f3
Make minor version a constant
mjbvz Aug 5, 2016
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Build/BuildReleaseHelpers.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function begin_sign_files {
$job.SelectCertificate("67") # StrongName key
}
if ($certificates -match "vsix") {
$job.SelectCertificate("10040160") # Microsoft OPC Publisher (VSIX)
$job.SelectCertificate("160") # Microsoft OPC Publisher (VSIX)
}

foreach ($approver in $approvers) {
Expand Down
4 changes: 2 additions & 2 deletions Build/BuildReleaseMockHelpers.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ job.SelectCertificate(67)"
}
if ($certificates -match "vsix") {
$msg = "$msg
job.SelectCertificate(100040160)"
$job.SelectCertificate("100040160") # Microsoft OPC Publisher (VSIX)
job.SelectCertificate(160)"
$job.SelectCertificate("160") # Microsoft OPC Publisher (VSIX)
}

foreach ($approver in $approvers) {
Expand Down
35 changes: 1 addition & 34 deletions Build/Common.Build.VSSDK.targets
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
</ItemGroup>
</Target>

<Target Name="_RezipSingleVSIX_Dev12" DependsOnTargets="_GetRezipVSIXFiles" BeforeTargets="Build" Inputs="@(VSIX)" Outputs="%(VSIX.Container)" Condition="'$(VSTarget)' == '12.0'">
<Target Name="_RezipSingleVSIX_Dev15" DependsOnTargets="_GetRezipVSIXFiles" BeforeTargets="Build" Inputs="@(VSIX)" Outputs="%(VSIX.Container)" Condition="'$(VSTarget)' == '15.0'">
<Message Text="Rezipping %(VSIX.SourceDir)" Importance="high" />

<ItemGroup>
Expand Down Expand Up @@ -234,39 +234,6 @@
Condition="'$(CopyOutputsToPath)' != ''" />
</Target>

<Target Name="_RezipSingleVSIX_Dev10_11" DependsOnTargets="_GetRezipVSIXFiles" BeforeTargets="Build" Inputs="@(VSIX)" Outputs="%(VSIX.Container)" Condition="'$(VSTarget)' == '10.0' or '$(VSTarget)' == '11.0'">
<Message Text="Rezipping %(VSIX.SourceDir)" Importance="high" />

<ItemGroup>
<_VSIXSourceItems Include="%(VSIX.SourceDir)**\*" />
<_VSIXSourceItems>
<TargetPath>%(RecursiveDir)%(Filename)%(Extension)</TargetPath>
</_VSIXSourceItems>
</ItemGroup>

<PropertyGroup>
<_Container>%(VSIX.Container)</_Container>
</PropertyGroup>

<CreateZipPackage Files="@(_VSIXSourceItems)"
ZipPackage="$(_Container)">
<Output TaskParameter="ZipPackage" ItemName="FileWrites" />
</CreateZipPackage>

<!-- Copy rezipped VSIX to output if necessary -->
<PropertyGroup Condition="'$(CopyOutputsToPath)' != ''">
<CopyOutputsToPath Condition="!HasTrailingSlash($(CopyOutputsToPath))">$(CopyOutputsToPath)\</CopyOutputsToPath>
<_PathSuffix Condition="'$(SignedBinariesPath)' != ''">SignedBinariesUnsignedMsi\</_PathSuffix>
<_PathSuffix Condition="'$(SignedBinariesPath)' == ''">UnsignedMsi\</_PathSuffix>
</PropertyGroup>

<MakeDir Directories="$(CopyOutputsToPath)$(_PathSuffix)"
Condition="'$(CopyOutputsToPath)' != ''" />
<Copy SourceFiles="$(_Container)"
DestinationFolder="$(CopyOutputsToPath)$(_PathSuffix)"
Condition="'$(CopyOutputsToPath)' != ''" />
</Target>

<!--
Transforms TransformedZipProject items into ZipProject items with textual
replacement of the VS target version.
Expand Down
2 changes: 1 addition & 1 deletion Build/Common.Build.Wix.targets
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

<Target Name="_CopyWixOutputsToPath"
AfterTargets="AfterBuild"
Condition="'$(CopyOutputsToPath)' != '' and $(OutputType) == 'Package'">
Condition="'$(CopyOutputsToPath)' != '' and ($(OutputType) == 'Package' or $(OutputType) == 'Vsix')">
<PropertyGroup>
<CopyOutputsToPath Condition="!HasTrailingSlash($(CopyOutputsToPath))">$(CopyOutputsToPath)\</CopyOutputsToPath>
<_PathSuffix Condition="'$(SignedBinariesPath)' != ''">SignedBinariesUnsignedMsi\</_PathSuffix>
Expand Down
4 changes: 4 additions & 0 deletions Build/Common.Build.settings
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@
<BuildRoot Condition="'$(BuildRoot)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), build.root))</BuildRoot>
<BuildRoot Condition="!HasTrailingSlash($(BuildRoot))">$(BuildRoot)\</BuildRoot>
<TargetsPath>$(BuildRoot)Build</TargetsPath>

<PackagesPath Condition="'$(PackagesPath)' == ''">$(BUILD_BINARIESDIRECTORY)</PackagesPath>
<PackagesPath Condition="'$(PackagesPath)' == ''">$(BuildRoot)\packages\</PackagesPath>
<PackagesPath Condition="!HasTrailingSlash($(PackagesPath))">$(PackagesPath)\</PackagesPath>

<!-- BuildOutputRoot contains all build files.

Expand Down
51 changes: 33 additions & 18 deletions EnvironmentSetup.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,36 @@

[CmdletBinding()]
param(
[string[]] $vstarget
[string[]] $vstarget,
[switch] $microbuild,
[switch] $skipTestHost
)

If (-not ([Security.Principal.WindowsPrincipal] [Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole(`
[Security.Principal.WindowsBuiltInRole] "Administrator")) {
If ((-not ([Security.Principal.WindowsPrincipal] [Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole(`
[Security.Principal.WindowsBuiltInRole] "Administrator")) -and (-not $microbuild)) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean this up

Throw "You do not have Administrator rights to run this script. Please re-run as an Administrator."
}

$rootDir = $PSScriptRoot
Write-Output "Repository root: $($rootDir)"
Write-Output ""


Import-Module -Force $rootDir\Build\VisualStudioHelpers.psm1
$target_versions = get_target_vs_versions $vstarget

Write-Output "Setting up NTVS development environment for $([String]::Join(", ", ($target_versions | % { $_.name })))"
Write-Output "============================================================"
$packagedir = if ($env:BUILD_BINARIESDIRECTORY) { "$env:BUILD_BINARIESDIRECTORY" } else { "$rootdir\packages" }

# Install microbuild packages
if ($microbuild) {
Write-Output ""
Write-Output "Installing Nuget MicroBuild packages"

& "$rootdir\Nodejs\.nuget\nuget.exe" restore "$rootdir\Nodejs\Setup\swix\packages.config" -PackagesDirectory "$packagedir"
exit
}

# Disable strong name verification for the Node.js Tools binaries
$skipVerificationKey = If ( $ENV:PROCESSOR_ARCHITECTURE -eq "AMD64") {"EnableSkipVerification.reg" } Else {"EnableSkipVerification86.reg" }
Expand All @@ -59,22 +72,24 @@ foreach ($version in $target_versions) {
}

# Install VSTestHost
Write-Output ""
Write-Output "Installing VSTestHost automation"
$vsTestHostLocation = "$rootDir\Common\Tests\Prerequisites\VSTestHost.msi"
Write-Output " $($vsTestHostLocation)"

# Check installed VSTestHost versions
$shouldInstallVSTestHost = $false
$gacDir = "${env:windir}\Microsoft.NET\assembly\GAC_MSIL"
foreach ($version in $target_versions) {
$currentVSTestHost = ls $gacDir -Recurse | ?{$_.Name -eq "Microsoft.VisualStudioTools.VSTestHost.$($version.number).dll"}

$targetVSTestHostVersion = "$($version.number).1.0"
if ((-not $currentVSTestHost) -or ($currentVSTestHost.VersionInfo.FileVersion -ne $targetVSTestHostVersion)) {
Write-Warning "VSTestHost already installed. Overriding VSTestHost version $($currentVSTestHost.VersionInfo.FileVersion) with target VSTestHostVersion $targetVSTestHostVersion"
$shouldInstallVSTestHost = $true
break
if (-not $skipTestHost) {
Write-Output ""
Write-Output "Installing VSTestHost automation"
$vsTestHostLocation = "$rootDir\Common\Tests\Prerequisites\VSTestHost.msi"
Write-Output " $($vsTestHostLocation)"

# Check installed VSTestHost versions
$gacDir = "${env:windir}\Microsoft.NET\assembly\GAC_MSIL"
foreach ($version in $target_versions) {
$currentVSTestHost = ls $gacDir -Recurse | ?{$_.Name -eq "Microsoft.VisualStudioTools.VSTestHost.$($version.number).dll"}

$targetVSTestHostVersion = "$($version.number).1.0"
if ((-not $currentVSTestHost) -or ($currentVSTestHost.VersionInfo.FileVersion -ne $targetVSTestHostVersion)) {
Write-Warning "VSTestHost already installed. Overriding VSTestHost version $($currentVSTestHost.VersionInfo.FileVersion) with target VSTestHostVersion $targetVSTestHostVersion"
$shouldInstallVSTestHost = $true
break
}
}
}

Expand Down
9 changes: 9 additions & 0 deletions Nodejs/.nuget/NuGet.Config
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,13 @@
<solution>
<add key="disableSourceControlIntegration" value="true" />
</solution>

<activePackageSource>
<add key="All" value="(Aggregate source)" />
</activePackageSource>
<packageSources>
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
<add key="microbuild" value="https://devdiv.pkgs.visualstudio.com/DefaultCollection/_packaging/MicroBuildToolset/nuget/v3/index.json"/>
</packageSources>
<disabledPackageSources />
</configuration>
Binary file modified Nodejs/.nuget/NuGet.exe
Binary file not shown.
12 changes: 2 additions & 10 deletions Nodejs/Product/AssemblyVersion.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
//*********************************************************//

using System.Reflection;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;

// If you get compiler errors CS0579, "Duplicate '<attributename>' attribute", check your
// Properties\AssemblyInfo.cs file and remove any lines duplicating the ones below.
Expand All @@ -42,13 +40,7 @@ class AssemblyVersionInfo {
// This version should never change from "4100.00"; BuildRelease.ps1
// will replace it with a generated value.
public const string BuildNumber = "4100.00";
#if DEV11
public const string VSMajorVersion = "11";
const string VSVersionSuffix = "2012";
#elif DEV12
public const string VSMajorVersion = "12";
const string VSVersionSuffix = "2013";
#elif DEV14
#if DEV14
public const string VSMajorVersion = "14";
const string VSVersionSuffix = "2015";
#elif DEV15
Expand All @@ -61,7 +53,7 @@ class AssemblyVersionInfo {
public const string VSVersion = VSMajorVersion + ".0";

// Defaults to "1.0.0.(2012|2013|2015)"
public const string StableVersion = ReleaseVersion + "." + VSVersionSuffix;
public const string StableVersion = ReleaseVersion + ".0." + VSVersionSuffix;

// Defaults to "1.2.4100.00"
public const string Version = FileVersion + "." + BuildNumber;
Expand Down
4 changes: 4 additions & 0 deletions Nodejs/Product/InteractiveWindow/InteractiveWindow.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,10 @@
<PropertyGroup>
<DelaySign>true</DelaySign>
</PropertyGroup>
<PropertyGroup>
<CreateVsixContainer>True</CreateVsixContainer>
<CopyVsixExtensionFiles>True</CopyVsixExtensionFiles>
</PropertyGroup>
<Import Project="$(BuildRoot)\Common\Product\ReplWindow\ReplWindow.proj" />
<Import Project="..\ProjectAfter.settings" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Expand Down
4 changes: 3 additions & 1 deletion Nodejs/Product/InteractiveWindow/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@

using System.Reflection;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using Microsoft.VisualStudio.Shell;

[assembly: AssemblyTitle("Node.js Tools for Visual Studio - Interactive Window")]
[assembly: AssemblyDescription("")]
[assembly: AssemblyConfiguration("")]

[assembly: ProvideCodeBase(AssemblyName = "Microsoft.NodejsTools.InteractiveWindow", CodeBase = "Microsoft.NodejsTools.InteractiveWindow.dll", Version = AssemblyVersionInfo.StableVersion)]

[assembly: InternalsVisibleTo("TestUtilities.UI, PublicKey=002400000480000094000000060200000024000052534131000400000100010007d1fa57c4aed9f0a32e84aa0faefd0de9e8fd6aec8f87fb03766c834c99921eb23be79ad9d5dcc1dd9ad236132102900b723cf980957fc4e177108fc607774f29e8320e92ea05ece4e821c0a5efe8f1645c4c0c93c1ab99285d622caa652c1dfad63d745d6f2de5f17e5eaf0fc4963d261c8a12436518206dc093344d5ad293")]
[assembly: InternalsVisibleTo("ReplWindowUITests, PublicKey=002400000480000094000000060200000024000052534131000400000100010007d1fa57c4aed9f0a32e84aa0faefd0de9e8fd6aec8f87fb03766c834c99921eb23be79ad9d5dcc1dd9ad236132102900b723cf980957fc4e177108fc607774f29e8320e92ea05ece4e821c0a5efe8f1645c4c0c93c1ab99285d622caa652c1dfad63d745d6f2de5f17e5eaf0fc4963d261c8a12436518206dc093344d5ad293")]
[assembly: InternalsVisibleTo("Nodejs.Tests.UI, PublicKey=002400000480000094000000060200000024000052534131000400000100010007d1fa57c4aed9f0a32e84aa0faefd0de9e8fd6aec8f87fb03766c834c99921eb23be79ad9d5dcc1dd9ad236132102900b723cf980957fc4e177108fc607774f29e8320e92ea05ece4e821c0a5efe8f1645c4c0c93c1ab99285d622caa652c1dfad63d745d6f2de5f17e5eaf0fc4963d261c8a12436518206dc093344d5ad293")]
Expand Down
55 changes: 24 additions & 31 deletions Nodejs/Product/InteractiveWindow/source.extension.vsixmanifest
Original file line number Diff line number Diff line change
@@ -1,34 +1,27 @@
<?xml version="1.0" encoding="utf-8"?>
<Vsix xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" Version="1.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2010">
<Identifier Id="29102E6C-34F2-4FF1-BA2F-C02ADE3846E8">
<Name>Node.js Tools - Interactive Window</Name>
<Author>Microsoft</Author>
<Version>1.2</Version>
<Description xml:space="preserve">Node.js Tools - Interactive Window</Description>
<MoreInfoUrl>http://go.microsoft.com/fwlink/?LinkId=785971</MoreInfoUrl>
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
<Metadata>
<Identity Id="29102E6C-34F2-4FF1-BA2F-C02ADE3846E8" Version="1.2" Language="en-US" Publisher="Microsoft" />
<DisplayName>Node.js Tools - Interactive Window</DisplayName>
<Description xml:space="preserve">Node.js Tools - Interactive Window.</Description>
<MoreInfo>http://go.microsoft.com/fwlink/?LinkId=785971</MoreInfo>
<GettingStartedGuide>http://go.microsoft.com/fwlink/?LinkId=785972</GettingStartedGuide>
<Locale>1033</Locale>
<InstalledByMsi>true</InstalledByMsi>
<Icon>NodeJS.ico</Icon>
<PreviewImage>NodeJS_200x.png</PreviewImage>
<SystemComponent>false</SystemComponent>
<SupportedProducts>
<VisualStudio Version="11.0">
<Edition>Pro</Edition>
<Edition>VWDExpress</Edition>
</VisualStudio>
</SupportedProducts>
<SupportedFrameworkRuntimeEdition MinVersion="4.0" />
</Identifier>
<References>
<Reference Id="Microsoft.VisualStudio.MPF" MinVersion="10.0">
<Name>Visual Studio MPF</Name>
</Reference>
</References>
<Content>
<VsPackage>|%CurrentProject%;PkgdefProjectOutputGroup|</VsPackage>
<MefComponent>|%CurrentProject%|</MefComponent>
<Assembly AssemblyName="|%CurrentProject%;_GetAssemblyName|">|%CurrentProject%|</Assembly>
</Content>

</Vsix>
</Metadata>
<!-- Version="11.0" specifies the minimum (not the maximum) version, and the
Id specifications are minimums; any SKU equal or 'higher' will accept
them. -->
<Installation>
<InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.Community" />
<InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.Pro" />
<InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.Enterprise" />
<InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.VSWinExpress" />
<InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.VWDExpress" />
<InstallationTarget Version="[14.0.0,16.0)" Id="Microsoft.VisualStudio.VSWinDesktopExpress" />
</Installation>
<Assets>
<Asset Type="Microsoft.VisualStudio.Package" Path="|%CurrentProject%|" d:Source="Project" d:ProjectName="%CurrentProject%" />
<Asset Type="Microsoft.VisualStudio.Assembly" Path="|%CurrentProject%|" />
<Asset Type="Microsoft.VisualStudio.MefComponent" Path="|%CurrentProject%|" />
</Assets>
</PackageManifest>
2 changes: 1 addition & 1 deletion Nodejs/Product/Nodejs/Microsoft.NodejsTools.targets
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
<Target Name="CopyFilesToOutputDirectory"/>

<Target Name="CoreCompile">
<Error Condition="!Exists('$(VSToolsPath)\TypeScript\Microsoft.TypeScript.targets') And '$(EnableTypeScript)' == 'true'" Text="TypeScript is not installed but TypeScript support is enabled in this project. Please download and install TypeScript http://go.microsoft.com/fwlink/?LinkID=393159&amp;clcid=0x409."></Error>
<Error Condition="!Exists('$(VSToolsPath)\TypeScript\Microsoft.TypeScript.targets') And '$(EnableTypeScript)' == 'true' And '$(VisualStudioVersion)' != '15.0'" Text="TypeScript is not installed but TypeScript support is enabled in this project. Please download and install TypeScript http://go.microsoft.com/fwlink/?LinkID=393159&amp;clcid=0x409."></Error>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I see. "Import Project" includes the fallback msbuild behavior, but not errors/messages because they are less constrained in their use case. Given that restriction, this appears to be the correct fix, though we should probably add a comment to clarify.

<PropertyGroup>
<_NodeModulesContentProperty>@(NodeModulesContent)</_NodeModulesContentProperty>
</PropertyGroup>
Expand Down
45 changes: 0 additions & 45 deletions Nodejs/Product/Nodejs/Navigation/IScopeNode.cs

This file was deleted.

Loading