Conversation
The Id is pulled from the vspackage.resx file (and the matching localized files)
paulvanbrenk
force-pushed
the
azureTemplateFix
branch
2 times, most recently
from
a15a99a to
f4c0667
Compare
paulvanbrenk
force-pushed
the
azureTemplateFix
branch
from
f4c0667 to
37edbc7
Compare
|
|
||
| module.exports = app; | ||
| var server = app.listen(app.get('port'), function () { | ||
| debug('Express server listening on port ' + server.address().port); |
There was a problem hiding this comment.
Did you try running this and seeing if there are errors? I don't see where 'debug' is defined/imported, so I assume this line throws.
There was a problem hiding this comment.
Forgot to comment that out in the template.
comment out debug statement
| <!-- Remote debugging (Azure Website with git deploy): Uncomment NtvsDebugProxy handler below. | ||
| Additionally copy Microsoft.NodejsTools.WebRole to 'bin' from the Remote Debug Proxy folder.--> | ||
| <!--<add name="NtvsDebugProxy" path="ntvs-debug-proxy/$guid2$" verb="*" resourceType="Unspecified" | ||
| type="Microsoft.NodejsTools.Debugger.WebSocketProxy, Microsoft.NodejsTools.WebRole"/>--> |
There was a problem hiding this comment.
So still removing this bit then - not needed?
There was a problem hiding this comment.
Missed in reverting change
| </ZipProject> | ||
| <ZipProject Include="ProjectTemplates\AzureNodejsApp\Web.config" /> | ||
| <ZipProject Include="ProjectTemplates\AzureNodejsApp\node.cmd" /> | ||
| <ZipProject Include="ProjectTemplates\AzureNodejsApp\iisnode.yml" /> |
There was a problem hiding this comment.
Why are you leaving the iisnode.yml file in some templates, and not others? Is it needed in some?
There was a problem hiding this comment.
removed from the actual projects, put left in the csproj file by accident. Removed now
| "description": "$projectname$", | ||
| "main": "app.js", | ||
| "scripts": { | ||
| "start": "node server" |
There was a problem hiding this comment.
Did the main module change from app.js to server.js?
| "description": "$projectname$", | ||
| "main": "app.js", | ||
| "scripts": { | ||
| "start": "node server" |
There was a problem hiding this comment.
yep changed from app to server
|
|
||
| module.exports = app; | ||
| var server = app.listen(app.get('port'), function () { | ||
| debug('Express server listening on port ' + server.address().port); |
|
|
||
| module.exports = app; | ||
| var server = app.listen(app.get('port'), function () { | ||
| debug('Express server listening on port ' + server.address().port); |
billti
left a comment
billti
left a comment
There was a problem hiding this comment.
If you've actually verified the worker stuff role works with these changes (which is different in behavior to an Azure Web App), then looks good to me - thanks!
3 participants
The NodeJs templates in VS no longer work on Azure. This cleans up the templates to they work without changes.